Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Hide unused addresses in dashboard + remove button #110

Open
sugoibtc opened this issue Mar 27, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@sugoibtc
Copy link

Describe the bug
Users are currently able to add "x" addresses in the "Options" tab, but are unable to remove them unless they clear the cache of the wallet.

These addresses will also show up in the "Dashboard" tab, which the user is unable to hide if they want.

To Reproduce
Steps to reproduce the behavior:

  1. Go to "Options" tab
  2. Click on 'add x addresses'
  3. See error

Expected behavior
The ability to remove/hide addresses at will.

Actual behavior
Missing feature.

Workaround
Clearing the cache of the wallet.

Screenshots
"Options" tab
image

"Dashboard" tab
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Syrius Version: 0.1.0
  • Commit hash: 267950f

Additional context
N/A

Bounty program
N/A

@KingGorrin
Copy link
Collaborator

BIP44 account usage recommendation.

Software should prevent a creation of an account if a previous account does not have a transaction history (meaning none of its addresses have been used before).

Software needs to discover all used accounts after importing the seed from an external source. Such an algorithm is described in "Account discovery" chapter.

Syrius v0.2.1 allows multiple account creation without having transaction history and does not have account discovery. In that regard it violates the recommendation.

The Ledger Live application combines both. It uses account discovery to select unused/used accounts to add. Depending on the chain, it also allows to filter on chain specifics like Native Segwit only addresses. Once an account is added, it can be removed or added to a favorites list.

Something similar could be done for syrius. Adding accounts will open an account discovery dialog in which one could traverse the account indexes until a suiteable account is found to be added to the active accounts.

Account discovery can also be used to quickly recover any used addresses or addresses with funds when doing a clean install or after a cache reset.

@KingGorrin KingGorrin added the enhancement New feature or request label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants