Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAST Request Uri macro's defined by IAB are not replaced for wrappers #70

Open
hwde opened this issue Mar 4, 2019 · 1 comment
Open

Comments

@hwde
Copy link

hwde commented Mar 4, 2019

i.e. [CACHEBUSTING] or [TIMESTAMP].

VAST 4.1 adds some more macro's, however the replacements for the macro's may only available if a videoplayer uses this module somehow. Would be cool if there is some kind of config to pass in the replacements.
Please drop me a note if you already have an idea how to integrate this.

@timdp
Copy link
Member

timdp commented Mar 5, 2019

Thanks for the report!

To my best knowledge, before VAST 4.1, the standard VAST macros could only occur in tracking URLs. However, VAST 4.1 indeed adds them to the VAST request as well and extends the list of available macros. I actually did an IAB Tech Lab talk advocating for adoption of those macros so we definitely want to support them in our code as well. 🙂

Unfortunately, iab-vast-loader doesn't have support for VAST 4.1 today. We do however have an internal roadmap that includes adding VAST 4.1 support to iab-vast-model, -parser, and -loader, including support for macros. I can't share an ETA but know that it's in the works.

In the meantime, one workaround would be to extend VASTLoader.prototype.load to alter this._uri:

const original = VASTLoader.prototype.load
VASTLoader.prototype.load = function () {
  this._uri = replaceMacros(uri)
  return original.call(this)
}

I'm not saying that it's an elegant solution, but if you urgently need macro support, this could be a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants