From 0f177b11b32b613c82b845fc3a319df22342aabb Mon Sep 17 00:00:00 2001 From: Bernard Normier Date: Thu, 18 Jan 2024 15:45:50 -0500 Subject: [PATCH] Remove f ice (#1686) --- cpp/include/Ice/LocatorF.h | 78 +++++++++++++++ cpp/include/Ice/ObjectAdapter.h | 2 + cpp/include/Ice/Proxy.h | 37 +------ cpp/include/Ice/RouterF.h | 61 ++++++++++++ cpp/src/Ice/msbuild/ice++11/ice++11.vcxproj | 98 ------------------- .../msbuild/ice++11/ice++11.vcxproj.filters | 54 ---------- cpp/src/Ice/msbuild/ice/ice.vcxproj | 98 ------------------- cpp/src/Ice/msbuild/ice/ice.vcxproj.filters | 54 ---------- cpp/src/IceBridge/IceBridge.cpp | 1 + js/src/Ice/sources.json | 2 - objective-c/include/objc/Ice/LocatorF.h | 35 +++++++ slice/Ice/LocatorF.ice | 28 ------ slice/Ice/RouterF.ice | 27 ----- 13 files changed, 179 insertions(+), 396 deletions(-) create mode 100644 cpp/include/Ice/LocatorF.h create mode 100644 cpp/include/Ice/RouterF.h create mode 100644 objective-c/include/objc/Ice/LocatorF.h delete mode 100644 slice/Ice/LocatorF.ice delete mode 100644 slice/Ice/RouterF.ice diff --git a/cpp/include/Ice/LocatorF.h b/cpp/include/Ice/LocatorF.h new file mode 100644 index 00000000000..c8c5627730f --- /dev/null +++ b/cpp/include/Ice/LocatorF.h @@ -0,0 +1,78 @@ +// +// Copyright (c) ZeroC, Inc. All rights reserved. +// + +#ifndef ICE_LOCATOR_F_H +#define ICE_LOCATOR_F_H + +// TODO: remove this include when we remove the C++98 mapping. +#include + +#include "Config.h" +#include +#include "ProxyF.h" +#include "SharedPtr.h" + +#ifdef ICE_CPP11_MAPPING // C++11 mapping + +namespace Ice +{ + +class Locator; +class LocatorPrx; +class LocatorRegistry; +class LocatorRegistryPrx; + +using LocatorPtr = ::std::shared_ptr; +using LocatorPrxPtr = ::std::shared_ptr; + +using LocatorRegistryPtr = ::std::shared_ptr; +using LocatorRegistryPrxPtr = ::std::shared_ptr; + +} + +#else // C++98 mapping + +namespace Ice +{ + class InputStream; +} + +namespace IceProxy::Ice +{ + +class Locator; +/// \cond INTERNAL +ICE_API void _readProxy(::Ice::InputStream*, ::IceInternal::ProxyHandle< Locator>&); +ICE_API ::IceProxy::Ice::Object* upCast(Locator*); +/// \endcond + +class LocatorRegistry; +/// \cond INTERNAL +ICE_API void _readProxy(::Ice::InputStream*, ::IceInternal::ProxyHandle< LocatorRegistry>&); +ICE_API ::IceProxy::Ice::Object* upCast(LocatorRegistry*); +/// \endcond + +} + +namespace Ice +{ + +typedef ::IceInternal::ProxyHandle< ::IceProxy::Ice::Locator> LocatorPrx; +typedef LocatorPrx LocatorPrxPtr; + +class Locator; +using LocatorPtr = ::Ice::SharedPtr< Locator>; +typedef ::IceInternal::ProxyHandle< ::IceProxy::Ice::LocatorRegistry> LocatorRegistryPrx; +typedef LocatorRegistryPrx LocatorRegistryPrxPtr; + +class LocatorRegistry; +using LocatorRegistryPtr = ::Ice::SharedPtr< LocatorRegistry>; + +} + +#endif + +// TODO: remove this include when we remove the C++98 mapping. +#include +#endif diff --git a/cpp/include/Ice/ObjectAdapter.h b/cpp/include/Ice/ObjectAdapter.h index aa38bd4e9f9..e25f8facce8 100644 --- a/cpp/include/Ice/ObjectAdapter.h +++ b/cpp/include/Ice/ObjectAdapter.h @@ -8,9 +8,11 @@ #include "Config.h" #include "CommunicatorF.h" #include "Ice/LocatorF.h" +#include "Endpoint.h" #include "FacetMap.h" #include "SharedPtr.h" #include "ServantLocator.h" +#include "Proxy.h" namespace Ice { diff --git a/cpp/include/Ice/Proxy.h b/cpp/include/Ice/Proxy.h index 87acd9cb565..72f1344a0d8 100644 --- a/cpp/include/Ice/Proxy.h +++ b/cpp/include/Ice/Proxy.h @@ -18,8 +18,8 @@ #include #include #include -//#include // Can't include RouterF.h here, otherwise we have cyclic includes -//#include // Can't include LocatorF.h here, otherwise we have cyclic includes +#include +#include #include #include #include @@ -268,16 +268,6 @@ class ProxyFlushBatchPromise : public ProxyFlushBatchAsync, public PromiseInvoke namespace Ice { -class RouterPrx; -/// \cond INTERNAL -using RouterPrxPtr = ::std::shared_ptr<::Ice::RouterPrx>; -/// \endcond - -class LocatorPrx; -/// \cond INTERNAL -using LocatorPrxPtr = ::std::shared_ptr<::Ice::LocatorPrx>; -/// \endcond - class LocalException; class OutputStream; @@ -1596,32 +1586,9 @@ checkedCast(const ::std::shared_ptr& b, const std::string& f, const ::Ice::Co #else // C++98 mapping -namespace IceProxy -{ - -namespace Ice -{ - -/// \cond INTERNAL -class Locator; -ICE_API ::IceProxy::Ice::Object* upCast(::IceProxy::Ice::Locator*); - -class Router; -ICE_API ::IceProxy::Ice::Object* upCast(::IceProxy::Ice::Router*); -/// \endcond - -} - -} - namespace Ice { -typedef ::IceInternal::ProxyHandle< ::IceProxy::Ice::Router> RouterPrx; -typedef RouterPrx RouterPrxPtr; -typedef ::IceInternal::ProxyHandle< ::IceProxy::Ice::Locator> LocatorPrx; -typedef LocatorPrx LocatorPrxPtr; - class LocalException; class OutputStream; diff --git a/cpp/include/Ice/RouterF.h b/cpp/include/Ice/RouterF.h new file mode 100644 index 00000000000..aeeb7ab1759 --- /dev/null +++ b/cpp/include/Ice/RouterF.h @@ -0,0 +1,61 @@ +// +// Copyright (c) ZeroC, Inc. All rights reserved. +// + +#ifndef ICE_ROUTER_F_H +#define ICE_ROUTER_F_H + +// TODO: remove this include when we remove the C++98 mapping. +#include + +#include "Config.h" +#include +#include "ProxyF.h" +#include "SharedPtr.h" + +#ifdef ICE_CPP11_MAPPING // C++11 mapping + +namespace Ice +{ + +class Router; +class RouterPrx; + +using RouterPtr = ::std::shared_ptr; +using RouterPrxPtr = ::std::shared_ptr; + +} + +#else // C++98 mapping + +namespace Ice +{ + class InputStream; +} + +namespace IceProxy::Ice +{ + +class Router; +/// \cond INTERNAL +ICE_API void _readProxy(::Ice::InputStream*, ::IceInternal::ProxyHandle< Router>&); +ICE_API ::IceProxy::Ice::Object* upCast(Router*); +/// \endcond + +} + +namespace Ice +{ +typedef ::IceInternal::ProxyHandle< ::IceProxy::Ice::Router> RouterPrx; +typedef RouterPrx RouterPrxPtr; + +class Router; +using RouterPtr = ::Ice::SharedPtr< Router>; + +} + +#endif + +// TODO: remove this include when we remove the C++98 mapping. +#include +#endif diff --git a/cpp/src/Ice/msbuild/ice++11/ice++11.vcxproj b/cpp/src/Ice/msbuild/ice++11/ice++11.vcxproj index b4509e5b7e0..bbca3ff7042 100644 --- a/cpp/src/Ice/msbuild/ice++11/ice++11.vcxproj +++ b/cpp/src/Ice/msbuild/ice++11/ice++11.vcxproj @@ -133,14 +133,12 @@ - - @@ -215,12 +213,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -263,12 +255,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true @@ -305,12 +291,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -353,12 +333,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true @@ -395,12 +369,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -443,12 +411,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true @@ -485,12 +447,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -533,12 +489,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true @@ -693,12 +643,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -741,12 +685,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true @@ -783,12 +721,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -831,12 +763,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true @@ -873,12 +799,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -921,12 +841,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true @@ -963,12 +877,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -1011,12 +919,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true diff --git a/cpp/src/Ice/msbuild/ice++11/ice++11.vcxproj.filters b/cpp/src/Ice/msbuild/ice++11/ice++11.vcxproj.filters index e9aefbff76e..89ae81892c7 100644 --- a/cpp/src/Ice/msbuild/ice++11/ice++11.vcxproj.filters +++ b/cpp/src/Ice/msbuild/ice++11/ice++11.vcxproj.filters @@ -102,9 +102,6 @@ Source Files\Win32\Debug - - Source Files\Win32\Debug - Source Files\Win32\Debug @@ -120,9 +117,6 @@ Source Files\Win32\Debug - - Source Files\Win32\Debug - Source Files\Win32\Debug @@ -138,9 +132,6 @@ Source Files\x64\Debug - - Source Files\x64\Debug - Source Files\x64\Debug @@ -156,9 +147,6 @@ Source Files\x64\Debug - - Source Files\x64\Debug - Source Files\x64\Debug @@ -174,9 +162,6 @@ Source Files\Win32\Release - - Source Files\Win32\Release - Source Files\Win32\Release @@ -192,9 +177,6 @@ Source Files\Win32\Release - - Source Files\Win32\Release - Source Files\Win32\Release @@ -210,9 +192,6 @@ Source Files\x64\Release - - Source Files\x64\Release - Source Files\x64\Release @@ -228,9 +207,6 @@ Source Files\x64\Release - - Source Files\x64\Release - Source Files\x64\Release @@ -700,9 +676,6 @@ Header Files\Win32\Debug - - Header Files\Win32\Debug - Header Files\Win32\Debug @@ -718,9 +691,6 @@ Header Files\Win32\Debug - - Header Files\Win32\Debug - Header Files\Win32\Debug @@ -736,9 +706,6 @@ Header Files\x64\Debug - - Header Files\x64\Debug - Header Files\x64\Debug @@ -754,9 +721,6 @@ Header Files\x64\Debug - - Header Files\x64\Debug - Header Files\x64\Debug @@ -772,9 +736,6 @@ Header Files\Win32\Release - - Header Files\Win32\Release - Header Files\Win32\Release @@ -790,9 +751,6 @@ Header Files\Win32\Release - - Header Files\Win32\Release - Header Files\Win32\Release @@ -808,9 +766,6 @@ Header Files\x64\Release - - Header Files\x64\Release - Header Files\x64\Release @@ -826,9 +781,6 @@ Header Files\x64\Release - - Header Files\x64\Release - Header Files\x64\Release @@ -885,9 +837,6 @@ Slice Files - - Slice Files - Slice Files @@ -903,9 +852,6 @@ Slice Files - - Slice Files - Slice Files diff --git a/cpp/src/Ice/msbuild/ice/ice.vcxproj b/cpp/src/Ice/msbuild/ice/ice.vcxproj index fbf2edcfc2a..81ce1498d73 100644 --- a/cpp/src/Ice/msbuild/ice/ice.vcxproj +++ b/cpp/src/Ice/msbuild/ice/ice.vcxproj @@ -138,14 +138,12 @@ - - @@ -220,12 +218,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -268,12 +260,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true @@ -310,12 +296,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -358,12 +338,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true @@ -400,12 +374,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -448,12 +416,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true @@ -490,12 +452,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -538,12 +494,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true @@ -698,12 +648,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -746,12 +690,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true @@ -788,12 +726,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -836,12 +768,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true @@ -878,12 +804,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -926,12 +846,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true @@ -968,12 +882,6 @@ true ..\..\..\..\..\slice\Ice\Locator.ice - - true - true - true - ..\..\..\..\..\slice\Ice\LocatorF.ice - true true @@ -1016,12 +924,6 @@ true ..\..\..\..\..\slice\Ice\Router.ice - - true - true - true - ..\..\..\..\..\slice\Ice\RouterF.ice - true true diff --git a/cpp/src/Ice/msbuild/ice/ice.vcxproj.filters b/cpp/src/Ice/msbuild/ice/ice.vcxproj.filters index c02cdeaba4d..0215ad5a0a2 100644 --- a/cpp/src/Ice/msbuild/ice/ice.vcxproj.filters +++ b/cpp/src/Ice/msbuild/ice/ice.vcxproj.filters @@ -101,9 +101,6 @@ Source Files\Win32\Debug - - Source Files\Win32\Debug - Source Files\Win32\Debug @@ -119,9 +116,6 @@ Source Files\Win32\Debug - - Source Files\Win32\Debug - Source Files\Win32\Debug @@ -137,9 +131,6 @@ Source Files\x64\Debug - - Source Files\x64\Debug - Source Files\x64\Debug @@ -155,9 +146,6 @@ Source Files\x64\Debug - - Source Files\x64\Debug - Source Files\x64\Debug @@ -173,9 +161,6 @@ Source Files\Win32\Release - - Source Files\Win32\Release - Source Files\Win32\Release @@ -191,9 +176,6 @@ Source Files\Win32\Release - - Source Files\Win32\Release - Source Files\Win32\Release @@ -209,9 +191,6 @@ Source Files\x64\Release - - Source Files\x64\Release - Source Files\x64\Release @@ -227,9 +206,6 @@ Source Files\x64\Release - - Source Files\x64\Release - Source Files\x64\Release @@ -699,9 +675,6 @@ Header Files\Win32\Debug - - Header Files\Win32\Debug - Header Files\Win32\Debug @@ -717,9 +690,6 @@ Header Files\Win32\Debug - - Header Files\Win32\Debug - Header Files\Win32\Debug @@ -735,9 +705,6 @@ Header Files\x64\Debug - - Header Files\x64\Debug - Header Files\x64\Debug @@ -753,9 +720,6 @@ Header Files\x64\Debug - - Header Files\x64\Debug - Header Files\x64\Debug @@ -771,9 +735,6 @@ Header Files\Win32\Release - - Header Files\Win32\Release - Header Files\Win32\Release @@ -789,9 +750,6 @@ Header Files\Win32\Release - - Header Files\Win32\Release - Header Files\Win32\Release @@ -807,9 +765,6 @@ Header Files\x64\Release - - Header Files\x64\Release - Header Files\x64\Release @@ -825,9 +780,6 @@ Header Files\x64\Release - - Header Files\x64\Release - Header Files\x64\Release @@ -884,9 +836,6 @@ Slice Files - - Slice Files - Slice Files @@ -902,9 +851,6 @@ Slice Files - - Slice Files - Slice Files diff --git a/cpp/src/IceBridge/IceBridge.cpp b/cpp/src/IceBridge/IceBridge.cpp index 0292c7482ca..1c5361dd737 100644 --- a/cpp/src/IceBridge/IceBridge.cpp +++ b/cpp/src/IceBridge/IceBridge.cpp @@ -4,6 +4,7 @@ #include #include +#include #include #include #include diff --git a/js/src/Ice/sources.json b/js/src/Ice/sources.json index e01c5e351c3..814750d061f 100644 --- a/js/src/Ice/sources.json +++ b/js/src/Ice/sources.json @@ -8,7 +8,6 @@ "Ice/EndpointTypes.ice", "Ice/Identity.ice", "Ice/Locator.ice", - "Ice/LocatorF.ice", "Ice/Metrics.ice", "Ice/OperationMode.ice", "Ice/Process.ice", @@ -16,7 +15,6 @@ "Ice/PropertyDict.ice", "Ice/RemoteLogger.ice", "Ice/Router.ice", - "Ice/RouterF.ice", "Ice/Version.ice" ], diff --git a/objective-c/include/objc/Ice/LocatorF.h b/objective-c/include/objc/Ice/LocatorF.h new file mode 100644 index 00000000000..d43aefe1170 --- /dev/null +++ b/objective-c/include/objc/Ice/LocatorF.h @@ -0,0 +1,35 @@ +// +// Copyright (c) ZeroC, Inc. All rights reserved. +// + +// Ice version 3.7.10 +// Generated from file `LocatorF.ice' + +#import +#import +#import +#import +#import +#import +#import +#import + +#ifndef ICE_API +# if defined(ICE_STATIC_LIBS) +# define ICE_API /**/ +# elif defined(ICE_API_EXPORTS) +# define ICE_API ICE_DECLSPEC_EXPORT +# else +# define ICE_API ICE_DECLSPEC_IMPORT +# endif +#endif + +@protocol ICELocator; + +@protocol ICELocatorRegistry; + +@class ICELocatorPrx; +@protocol ICELocatorPrx; + +@class ICELocatorRegistryPrx; +@protocol ICELocatorRegistryPrx; diff --git a/slice/Ice/LocatorF.ice b/slice/Ice/LocatorF.ice deleted file mode 100644 index 4cac1aa64a6..00000000000 --- a/slice/Ice/LocatorF.ice +++ /dev/null @@ -1,28 +0,0 @@ -// -// Copyright (c) ZeroC, Inc. All rights reserved. -// - -#pragma once - -[["cpp:dll-export:ICE_API"]] -[["cpp:doxygen:include:Ice/Ice.h"]] -[["cpp:header-ext:h"]] - -[["ice-prefix"]] - -[["js:module:ice"]] -[["js:cjs-module"]] - -[["objc:dll-export:ICE_API"]] -[["objc:header-dir:objc"]] - -[["python:pkgdir:Ice"]] - -[["java:package:com.zeroc"]] - -["objc:prefix:ICE"] -module Ice -{ - interface Locator; - interface LocatorRegistry; -} diff --git a/slice/Ice/RouterF.ice b/slice/Ice/RouterF.ice deleted file mode 100644 index 3baa467c41a..00000000000 --- a/slice/Ice/RouterF.ice +++ /dev/null @@ -1,27 +0,0 @@ -// -// Copyright (c) ZeroC, Inc. All rights reserved. -// - -#pragma once - -[["cpp:dll-export:ICE_API"]] -[["cpp:doxygen:include:Ice/Ice.h"]] -[["cpp:header-ext:h"]] - -[["ice-prefix"]] - -[["js:module:ice"]] -[["js:cjs-module"]] - -[["objc:dll-export:ICE_API"]] -[["objc:header-dir:objc"]] - -[["python:pkgdir:Ice"]] - -[["java:package:com.zeroc"]] - -["objc:prefix:ICE"] -module Ice -{ - interface Router; -}