Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run rake from Swift CI #1669

Closed
bernardnormier opened this issue Jan 14, 2024 · 1 comment · Fixed by #1670
Closed

Run rake from Swift CI #1669

bernardnormier opened this issue Jan 14, 2024 · 1 comment · Fixed by #1670
Assignees
@externl
Labels
ci continuous integration swift
Milestone
3.8.0

Comments

@bernardnormier
Copy link
Member

Swift CI currently does not run rake.

As a result, a PR that changes to the list of C++ files included in the C++ build needs to run rake and include the generated Xcode project files (10,000+ lines of changes). This skews the size/complexity of the PR.

For example: #1668
These Xcode project aside, this PR changes only about 200 lines of code.

The solution is for the Swift CI to run rake. We should also consider not checking in these Xcode project files and always require rake.
@bernardnormier bernardnormier added swift ci continuous integration labels Jan 14, 2024
@bernardnormier bernardnormier added this to the 3.8.0 milestone Jan 14, 2024
@externl
Copy link
Member

externl commented Jan 15, 2024

I think the simplest is to remove these files from source control and have Make generate them.

@externl externl self-assigned this Jan 15, 2024
externl added a commit to externl/ice that referenced this issue Jan 15, 2024
@externl
Remove Swift ice.xcodeproj
7ae1db4 
The Make build system now regenerates this file every time
it is invoked

Closes zeroc-ice#1669
@externl externl mentioned this issue Jan 15, 2024
Merged
externl added a commit that referenced this issue Jan 16, 2024
@externl
Remove Swift ice.xcodeproj (#1670)
9b86faa 
Remove Swift ice.xcodeproj. The Make build system now regenerates this file every time
it is invoked

Closes #1669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@externl externl

Labels
ci continuous integration swift
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

Remove Swift ice.xcodeproj externl/ice
2 participants
@externl @bernardnormier