Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup var usage in JavaScript #2876

Open
pepone opened this issue Oct 9, 2024 · 0 comments
Open

Cleanup var usage in JavaScript #2876

pepone opened this issue Oct 9, 2024 · 0 comments
Milestone

Comments

@pepone
Copy link
Member

pepone commented Oct 9, 2024

We should not use var in modern JavaScript, it should be either let or const

jose@mac js % rg "var "
test/Slice/escape/Key.ice
54:    optional(2) var goto;
63:    optional(1) break for(optional(2) var goto,
70:    optional(1) break continue(optional(2) var goto,
76:    optional(1) break in(out optional(2) var goto,
83:    optional(1) break foreach(out optional(2) var goto,
122:    var in(break internal, delete is, explicit* lock, case* namespace, typeof* new, delete null,

src/Ice/IncomingRequest.js
35:        var identity = new Identity();
55:        var encoding = new EncodingVersion();

src/Ice/Properties.js
64:        var defaultValue = 0;
86:        var defaultPropertyList = StringUtil.splitString(Properties.getDefaultProperty(key), ", \t\r\n");
140:        var prop = Properties.findIceProperty(key, true);
440:        var propertyArray = null;

src/Ice/Reference.js
1030:        var handler = new ConnectRequestHandler(this);

test/Ice/middleware/Server.ts
17:            var response = await this._next.dispatch(request);

src/Ice/ConnectionI.js
1439:                var request = new IncomingRequest(requestId, this, adapter, stream);

test/Ice/timeout/Client.ts
45:            var properties = communicator.getProperties().clone();

src/Ice/OutgoingAsync.js
275:        var retryIntervals = instance._retryIntervals;

src/Ice/OutputStream.js
492:        var instance = null;
@pepone pepone added this to the 3.8.0 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant