Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve protocol tracing for collocated calls #3266

Open
pepone opened this issue Dec 13, 2024 · 0 comments
Open

Improve protocol tracing for collocated calls #3266

pepone opened this issue Dec 13, 2024 · 0 comments

Comments

@pepone
Copy link
Member

pepone commented Dec 13, 2024

In 3.8 we include tracing for the transport along with requests, for collocated calls we could include "collocated = true" to make clear that the transport info is not present because the requests is a collocated request.

See for example this tracing:

-- 12/12/24 18:11:30385 ./writer: Protocol: sending request 
   message type = 0 (request)
   compression status = 0 (not compressed; do not compress response, if any)
   message size = 159
   request id = 1
   identity = forwarders/2
   facet = 
   operation = announceTopicWriter
   mode = 2 (idempotent)
   context = 
   encoding = 1.1
....
-- 12/12/24 18:11:30386 ./writer: Protocol: sending request 
   message type = 0 (request)
   compression status = 0 (not compressed; do not compress response, if any)
   message size = 163
   request id = 0 (oneway)
   identity = DataStorm/Lookup
   facet = 
   operation = announceTopicWriter
   mode = 2 (idempotent)
   context = 
   encoding = 1.1
   transport = udp
   local address = 192.168.86.184:59947
   remote address = 239.255.0.1:10000

The initial announceTopicWriter send to forwarders/2 is a collocated requests, that is why it doesn't include any transport info. Adding collocated = true would make clear it is a collocated request.

@pepone pepone added this to the 3.8.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant