Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firefox] [extension] Video thumbnails do not unblur again - Follow up #172

Closed
1 task
THEtomaso opened this issue Jan 1, 2023 · 12 comments
Closed
1 task
Labels
bug Something isn't working

Comments

@THEtomaso
Copy link

What happened?

Reference:
#164 (comment)

I've researched this further now..

As I'm sure you know; everyone aren't served the same changes to YouTube simultaneously.
It depends on your regional location, amongst other things.

For me (who's located in Norway), the thumnails are blurred when using Age Restriction Bypass for YouTube v2.5.4.
Going back to v2.5.3 fixes the issue!

Platform

Extension

Version

v2.5.3 / v2.5.4

What browser are you on?

Other (mention below with version)

Browser version

LibreWolf v108.0.1-1 (x64) (Tracking Protection = Standard)

Link to the video

No response

Screenshots or Videos

No response

About you

  • I am a developer and/or have knowledge in programming
@THEtomaso THEtomaso added the bug Something isn't working label Jan 1, 2023
@drunkwinter
Copy link
Collaborator

Is there any way you could get me the image url of these blurred thumbnails? Right mouse click on the thumbnail and copy image address should do.

@THEtomaso
Copy link
Author

THEtomaso commented Jan 3, 2023

Sure, here you go..

Example:

https://www.youtube.com/results?search_query=avgn

Using Age Restriction Bypass for YouTube v2.5.3:

AgeRestrictionBypassForYouTube-BlurredImages-1

--

Using Age Restriction Bypass for YouTube v2.5.4:

AgeRestrictionBypassForYouTube-BlurredImages-2

Example image above (with the problematic parameter):

https://i.ytimg.com/vi/c8e9CJgFcYY/hq720.jpg?sqp=-oaymwEiCOgCEMoBSFXyq4qpAxQIARUAAIhCGAFwAcABBu0BZmbmQQ==&rs=AOn4CLBN1FZiSl2dnBWqOtpdwilD3jO4Pg

@drunkwinter
Copy link
Collaborator

Alright, apparently this is some other issue than just thumbnails that needs to be fixed. As a workaround you can temporarily use the userscript version.

@THEtomaso
Copy link
Author

THEtomaso commented Jan 3, 2023

As a workaround you can temporarily use the userscript version.

No need.
The extension v2.5.3 works just fine, like I pointed out. :)

--

EDIT:
Alternatively, this also works for me, in uBlock Origin:
||ytimg.com^$removeparam=sqp
..but I'm uncertain as to whether or not it might cause any side effects.

@drunkwinter
Copy link
Collaborator

As a workaround you can temporarily use the userscript version.

No need. The extension v2.5.3 works just fine, like I pointed out. :)

--

EDIT: Alternatively, this also works for me, in uBlock Origin: ||ytimg.com^$removeparam=sqp ..but I'm uncertain as to whether or not it might cause any side effects.

Nope that is kind of what we do. But the only downside doing it this way is performance. By removing the sqp parameter for all images, you cause all thumbnails to load at the highest resolution and possibly twice (not sure). We only remove the sqp parameter if the length is a specific size, meaning it's blurred.

@drunkwinter
Copy link
Collaborator

Also version 2.5.3 does not detect all blurred thumbnails.

@THEtomaso
Copy link
Author

OK, I'm sure you'll be able to come up with a proper fix. :)

@drunkwinter drunkwinter changed the title Video thumbnails do not unblur again - Follow up [firefox] [extension] Video thumbnails do not unblur again - Follow up Jan 3, 2023
@drunkwinter
Copy link
Collaborator

@zerodytrash Needs release.

@THEtomaso
Copy link
Author

Needs release.

Perhaps even a fork, it would seem..

@drunkwinter
Copy link
Collaborator

Things have changed a little. The extension got removed by Mozilla, because it was apparently violating their rules. I’m going to close this when there is a good way to do a manually install and a new release including the fix has been published.

@THEtomaso
Copy link
Author

THEtomaso commented Feb 20, 2023

Yeah, I noticed that.
I've switched to the user script version for now, and it works just fine! :)

@drunkwinter
Copy link
Collaborator

drunkwinter commented May 26, 2023

Fix for the thumbnail issue landed in 2.5.5.

Will have a look at a better way to do a manual install, when I got some time. (#182)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants