Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce automated authority migrations between releases #3402

Closed
CharlieMc0 opened this issue Jan 23, 2025 · 3 comments
Closed

Enforce automated authority migrations between releases #3402

CharlieMc0 opened this issue Jan 23, 2025 · 3 comments
Assignees
Labels
feature:idea An early idea for a feature. Used as reference to follow new feature integrations

Comments

@CharlieMc0
Copy link
Member

CharlieMc0 commented Jan 23, 2025

Is your feature request related to a problem? Please describe.

All required changes to authorization grants must include automated migration scripts.

Requiring manual adjustments to Authz breaks our ability to run upgrade tests in the CI, adds unnecessary operational overhead to node operators, and increases the chance that something goes wrong with the upgrade.

Describe the solution you'd like
This will be enforced with CI Checks and failing to automate authz changes will block a release.

Blocks: #2708

@CharlieMc0 CharlieMc0 added the feature:idea An early idea for a feature. Used as reference to follow new feature integrations label Jan 23, 2025
@lumtis
Copy link
Member

lumtis commented Jan 23, 2025

I would say "authority changes", authz is a different module.

@gartnera gartnera changed the title Enforce automated Authz migrations between releases Enforce automated authority migrations between releases Jan 23, 2025
@lumtis
Copy link
Member

lumtis commented Feb 3, 2025

I don't think there is anything to implement for this issue. The migration is implemented per new message.

If we want to detect the migration is missing, the best way is actually to add #2708, the test will fail in the CI as the authorization will not migrate

@lumtis
Copy link
Member

lumtis commented Feb 3, 2025

I will close this issue and put #2708 in the milestone instead, feel free to reopen if disagree

@lumtis lumtis closed this as completed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:idea An early idea for a feature. Used as reference to follow new feature integrations
Projects
None yet
Development

No branches or pull requests

3 participants