From 70b6e91d564d1df594973bd8a59110e799f90148 Mon Sep 17 00:00:00 2001 From: Joakim Plate Date: Fri, 26 Jul 2024 16:41:16 +0200 Subject: [PATCH 1/2] Don't hide handler exceptions behind debug --- zha/zigbee/endpoint.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zha/zigbee/endpoint.py b/zha/zigbee/endpoint.py index e222606c..1c0af824 100644 --- a/zha/zigbee/endpoint.py +++ b/zha/zigbee/endpoint.py @@ -204,7 +204,7 @@ async def _execute_handler_tasks( results = await gather(*tasks, return_exceptions=True) for cluster_handler, outcome in zip(cluster_handlers, results): if isinstance(outcome, Exception): - cluster_handler.debug( + cluster_handler.warning( "'%s' stage failed: %s", func_name, str(outcome), exc_info=outcome ) else: From f9279cdb9fa42c66049c7a7256e87104007196c6 Mon Sep 17 00:00:00 2001 From: Joakim Plate Date: Tue, 30 Jul 2024 03:36:43 +0200 Subject: [PATCH 2/2] Adjust test --- tests/test_cluster_handlers.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_cluster_handlers.py b/tests/test_cluster_handlers.py index a4c25cf3..2d6d4257 100644 --- a/tests/test_cluster_handlers.py +++ b/tests/test_cluster_handlers.py @@ -847,8 +847,8 @@ async def test_ep_cluster_handlers_configure(cluster_handler) -> None: assert ch.async_configure.call_count == 1 assert ch.async_configure.await_count == 1 - assert ch_3.debug.call_count == 2 - assert ch_5.debug.call_count == 2 + assert ch_3.warning.call_count == 2 + assert ch_5.warning.call_count == 2 async def test_poll_control_configure(