Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Marketplace: Delivery Fee may be a percentage of the Order Subtotal #2641

Closed
Tracked by #1325
zspencer opened this issue Oct 10, 2024 · 1 comment
Closed
Tracked by #1325

✨ Marketplace: Delivery Fee may be a percentage of the Order Subtotal #2641

zspencer opened this issue Oct 10, 2024 · 1 comment
Labels
✨ feature Reduces Client's Burden or Grants them Benefits

Comments

@zspencer
Copy link
Member

zspencer commented Oct 10, 2024 •
edited
Loading

For Catering, Piikup wants to charge a %age of the total order. For small orders, she wants a $10 minimum.

The way I think that makes sense to do this is to allow each delivery area to be either a $amount or a %age amount; and label the delivery areas "Catering to San Francisco" or "Personal Plates in East Bay"
@zspencer zspencer added the ✨ feature Reduces Client's Burden or Grants them Benefits label Oct 10, 2024
zspencer added a commit that referenced this issue Oct 10, 2024
@zspencer
Marketplace: DeliveryArea fees as a percentage
3fa0e5e 
- #2641

Todo:
- [x] A Delivery Area may have a Percentage fee
- [ ] Orders to a Delivery Area with a Percentage
      Fee calculate the fee correctly.
- [ ] `Shoppers` see a description of the Delivery Fee when building
      their Order.
@zspencer zspencer mentioned this issue Oct 10, 2024
Merged
3 tasks
zspencer added a commit that referenced this issue Oct 10, 2024
@zspencer
Marketplace: DeliveryArea fees as a percentage (#2643)
c8d1694 
- #2641

Todo:
- [x] A `DeliveryArea` may have a delivery fee as a percentage
- [x] `Orders` to a `DeliveryArea` with a Percentage Fee calculate the fee correctly.
- [x] `Shoppers` see a description of the Delivery Fee when building their Order.

April has adjusted her fee schedule, and catering orders are now 12% and regular orders are $10 flat. This simplifies things quite a bit; hooray! But alas, we had already built out stuff to support different fees for every vendor and across regions (i.e. SF it's $20, Oakland it's $10)

I think it's probably for the best to leave that flexibility in for now, and have updated it so we now have another attribute for how to calculate fees.

I've made the Executive Decision to treat these fees as cumulative (i.e. $10 plus 12%) if both the `DeliveryArea#price` and the `DeliveryArea#fee_as_percentage` are set; rather than trying to figure out how to break ties or validate only one is set or whatever. This may be a poor decision.
@zspencer
Copy link
Member Author

I've let #832 know that this feature exists.

@zspencer zspencer mentioned this issue Oct 11, 2024
Closed
6 tasks
@zspencer zspencer changed the title Delivery fee can be a percentage of the order ✨ Marketplace: Delivery Fee may be a percentage of the Order Subtotal Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ feature Reduces Client's Burden or Grants them Benefits
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zspencer