Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About geo_loss #75

Open
kgkgkgjb opened this issue Dec 27, 2024 · 2 comments
Open

About geo_loss #75

kgkgkgjb opened this issue Dec 27, 2024 · 2 comments

Comments

@kgkgkgjb
Copy link

Thank you for your contribution!
The homography matrix in your paper was solved using renderd_normal and renderd_distance, and Lmvgeom was solved using this homography matrix. But in the code, only the plane_depth is used for geo_loss, and there is no correspondence between the paper and the code?

@danpeng2
Copy link
Contributor

Hello, the plane_depth is derived from rendered_normal and rendered_distance. The formula in the code is theoretically consistent with the one in the paper. For simplicity of implementation, we directly use plane_depth to calculate get_loss.

@Rickyeeeeee
Copy link

@kgkgkgjb actually there are two homographies calculated in the loss function code section, for the geo_loss(Lmvgeom) the homography is calculated from camera, and for the ncc_loss(Lmvrgb), the homography matrix is calculated using rendered_normal and rendered_distance as in the paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants