-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile to wasm32-unknown-unknown / Compile without terminal_size
#346
Comments
I'm ok putting it behind a feature flag but make it default as part of the fancy feature. Perhaps we can have a |
(that is, I'll take a patch to make these changes, and I can do a release after that for you) |
I have a few projects that are targeting wasm and wasi. I'd like to add a In this way we can put all This will also resolve issues like #326 where I want to explicitly control all syscalls. I'll draft a PR and see how it looks. |
I drafted a PR in #349 |
I'm currently stuck upgrading to v7 for wasm builds.
Background
After the
terminal_size
upgrade from #308, it brought in an extra dependencyrustix
, which in turn brought inerrrno
which doesn't support compile towasm32-unknown-unknown
.After looking at both crates
terminal_size
anderrno
, both crates claims they don't support wasm.Possible Solution
Given that
terminal_size
is only called when terminal width is not provided, I think it's reasonable to put it behind a feature flag.miette/src/handler.rs
Lines 374 to 381 in 75fea09
The text was updated successfully, but these errors were encountered: