Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid estimating fee if all values are provided #231

Open
petarTxFusion opened this issue Jan 17, 2025 · 0 comments
Open

Avoid estimating fee if all values are provided #231

petarTxFusion opened this issue Jan 17, 2025 · 0 comments
Assignees
@petarTxFusion
Labels
bug Something isn't working

Comments

@petarTxFusion
Copy link
Contributor

🐛 Bug Report for zksync-ethers JavaScript SDK

📝 Description

Avoid calling zks_estimateFee in populateTransaction if gasLimit, maxFeePerGas, maxPriorityFeePerGas and gasPerPubdataLimit are provided

Implement above mentioned for:

  • Wallet
  • SmartAccount
  • Signer
@petarTxFusion petarTxFusion added the bug Something isn't working label Jan 17, 2025
@petarTxFusion petarTxFusion self-assigned this Jan 17, 2025
@petarTxFusion petarTxFusion moved this to Todo in DevEx squad Jan 17, 2025
@petarTxFusion petarTxFusion moved this from Todo to In Progress in DevEx squad Jan 17, 2025
@petarTxFusion petarTxFusion moved this from In Progress to Done in DevEx squad Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petarTxFusion petarTxFusion

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petarTxFusion