Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Choose subtitle" button #563

Open
haashemi opened this issue Jul 14, 2024 · 3 comments
Open

Add "Choose subtitle" button #563

haashemi opened this issue Jul 14, 2024 · 3 comments
Labels
enhancement New feature or request front Change on the front-end side of the app
Milestone

Comments

@haashemi
Copy link

haashemi commented Jul 14, 2024

Feature description

Is your feature request related to a problem? If yes, please describe.

Most of the time, the video file we're going to watch doesn't have our own language's subtitle embedded (or it isn't good enough, at least with my language), so we'd like to add our own subtitle file from somewhere else.

Describe the feature you'd like

I'd like to have a "Choose subtitle" button somewhere in the player that accepts a URL to the subtitle or a file from the client's local storage.

Something like this:
image

Describe alternatives you've considered

Alternately, this "choose subtitle" button could be an "Add Subtitle" button somewhere before playing the video that (maybe?) adds the subtitle in its metadata folder. for example, somewhere like here:
image

Also, another way would be to load the video file's near .ass or .srt files.

ali@haashemi /v/w/storage> ls
'[SubsPlease] Dead Dead Demons Dededede Destruction - 06 (1080p) [44A567EE].mkv'
'[SubsPlease] Dead Dead Demons Dededede Destruction - 06 (1080p) [44A567EE].ass' # or 'Dead Dead Demons Dededede Destruction - 06.ass'
@haashemi haashemi added the enhancement New feature or request label Jul 14, 2024
@zoriya
Copy link
Owner

zoriya commented Jul 14, 2024

I don't want to have an "Add subtitle" button since the media library is read-only, but a "Choose subtitle" would be nice.

Finding subtitles files with just a different name is already tracked by: #253. The logic/code change needed for this to work will also be needed for #542, so I plan to do it in the following weeks!

@haashemi
Copy link
Author

Thanks! I appreciate your hard works. <3

@zoriya
Copy link
Owner

zoriya commented Jul 14, 2024

Unreleated but the anime name is kinda funny. I'll watch first ep to see what it's about

@zoriya zoriya changed the title [FEATURE] Support additional subtitle Add "Choose subtitle" button Aug 8, 2024
@zoriya zoriya added the front Change on the front-end side of the app label Aug 8, 2024
@zoriya zoriya added this to the Backlog milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request front Change on the front-end side of the app
Projects
None yet
Development

No branches or pull requests

2 participants