Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic subtitle selection improvements #588

Open
JeWe37 opened this issue Aug 8, 2024 · 2 comments
Open

Automatic subtitle selection improvements #588

JeWe37 opened this issue Aug 8, 2024 · 2 comments
Labels
enhancement New feature or request front Change on the front-end side of the app
Milestone

Comments

@JeWe37
Copy link

JeWe37 commented Aug 8, 2024

Feature description

It would make sense to automatically select subtitles for videos based on user preferences.

Examples

For instance a user, that only knows English and German, will want English or German non-forced subtitles if they are watching a Spanish show. Similarly, forced subtitles should always be automatically selected if their language matches the audio language and the user knows that language. Technically speaking default subtitles should always be turned on, but I find the tagging for those to be generally too inconsistent as to be worth considering. If two subtitles are of the same preference, some ranking should be done, perhaps based on the subtitle codec, preferring e.g. typically higher quality .ass subtitles. For accessibility, the user should probably be able to choose whether to prefer CC/SDH or non-CC/SDH subs.

References

For an approach for how to do the sorting, see for instance jellyfin/jellyfin#11072.

@JeWe37 JeWe37 added the enhancement New feature or request label Aug 8, 2024
@zoriya
Copy link
Owner

zoriya commented Aug 10, 2024

There is already an option for this:
image

Do you want improvements over this option? Right now, there is no CC/SDH special handling.

Forced subtitles are not automatically enabled when you select the corresponding audio, it could make a nice addition.

@JeWe37
Copy link
Author

JeWe37 commented Aug 10, 2024

Ah, I missed that one. Then indeed, let's change this to "Automatic subtitle selection improvements". Most of the ideas, SDH, handling multiple known languages, forced subtitle handling, as well as only activating subtitles for unknown languages still apply.

@JeWe37 JeWe37 changed the title Automatic subtitle selection Automatic subtitle selection improvements Aug 10, 2024
@zoriya zoriya added the front Change on the front-end side of the app label Aug 10, 2024
@zoriya zoriya added this to the Backlog milestone Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request front Change on the front-end side of the app
Projects
None yet
Development

No branches or pull requests

2 participants