-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab support #694
Comments
Thinking about this issue, it seems that the primary jobs to be done (JTBD) are
These could be implemented in several ways, e.g. using a Some comments on the JTBDs:
|
@dstillman do you have any comments on the above? |
We could do this just in the PDF reader, but I think it will make more sense to mirror the desktop app:
We should also open web snapshots in tabs.
Down the line, both on iOS and desktop, you'd be able to open a note in a tab too, for a full-window editing experience, and probably multiple library views (e.g., open a collection in a tab).
Logically the tab bar is the parent of each view, so we should try putting it above the toolbars, as we do on macOS. My only concern is that if you miss and tap the status bar, you could accidentally trigger the scroll-to-top behavior and lose your place, but let's see whether that actually happens.
And then the other general concern is just encroaching on reading space. We'd obviously hide this when hiding the status bar and main toolbar in the PDF reader, but since this will always be present we may want to experiment with auto-hiding on scroll like PDF Viewer does (and, slightly different conceptually but effectively the same, Safari when you scroll down).
The text was updated successfully, but these errors were encountered: