Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--show-inputs-only not working for zos-files copy data-set-cross-lpar #2446

Open
drb1972 opened this issue Feb 26, 2025 · 2 comments
Open

--show-inputs-only not working for zos-files copy data-set-cross-lpar #2446

drb1972 opened this issue Feb 26, 2025 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.

Comments

@drb1972
Copy link

drb1972 commented Feb 26, 2025

--show-inputs-only not showing values for zowe zos-files copy data-set-cross-lpar CLI command but executing the command directly (succesfully copied).

Expected: Display commandValues

Actual results:
PS C:\zowe>zowe zos-files copy data-set-cross-lpar PROD001.lib.del PROD001.lib.del.copy --target-zosmf-profile b043.zosmf --zosmf-profile r133.zosmf --show-inputs-only
Data set copied successfully.

CLI Version: 8.12.0
Zowe Release Version: v3.1.0
@broadcom/[email protected]
@broadcom/[email protected]
@broadcom/[email protected]
@broadcom/[email protected]
@broadcom/[email protected]
@broadcom/[email protected]
@microfocus/[email protected]
@zowe/[email protected]
@zowe/[email protected]
@zowe/[email protected]
@zowe/[email protected]
node: v20.18.0
npm: 9.2.0
ZOWE_SHOW_SECURE_ARGS = true
Windows 10 Pro 22H2
O.S. platform: win32
O.S. architecture: x64
powershell
Daemon mode disabled

@drb1972 drb1972 added bug Something isn't working new The issue wasn't triaged yet labels Feb 26, 2025
@github-project-automation github-project-automation bot moved this to New Issues in Zowe CLI Squad Feb 26, 2025
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@JTonda JTonda added good first issue Good for newcomers priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. and removed new The issue wasn't triaged yet labels Feb 26, 2025
@zowe-robot zowe-robot moved this from New Issues to Medium Priority in Zowe CLI Squad Feb 26, 2025
@awharn
Copy link
Member

awharn commented Feb 26, 2025

It appears showInputsOnly is not checked for commands using chained handlers, and only done for commands with a single handler.

For single handlers, the logic is here:

try {
if (handlerParms.arguments.showInputsOnly) {
this.showInputsOnly(response, handlerParms);
} else {
await handler.process(handlerParms);
}
} catch (processErr) {

For chained handlers, we would want to replicate the same behavior here:

try {
await handler.process({
response: chainedResponse,
arguments: ChainedHandlerService.getArguments(
this.mCommandRootName,
this.definition.chainedHandlers,
chainedHandlerIndex,
chainedResponses,
preparedArgs,
this.log
),
positionals: preparedArgs._,
definition: this.definition,
fullDefinition: this.fullDefinition,
stdin: this.getStdinStream(),
isChained: true
});
const builtResponse = chainedResponse.buildJsonResponse();
chainedResponses.push(builtResponse.data);
// save the stdout and stderr to pass to the next chained handler (if any)
bufferedStdOut = builtResponse.stdout;
bufferedStdErr = builtResponse.stderr;
} catch (processErr) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.
Projects
Status: Medium Priority
Development

No branches or pull requests

3 participants