Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Support Is Broken #11

Open
TurtleWilly opened this issue Sep 28, 2021 · 2 comments
Open

Proxy Support Is Broken #11

TurtleWilly opened this issue Sep 28, 2021 · 2 comments

Comments

@TurtleWilly
Copy link

helper.php/ submit_payload()

  • there seems to be some untested proxy support in the payload submit method. I haven't tested it either, but the usage of conf_decodeString ( $proxy['port'] ) clearly seems to be wrong. I guess $proxy['pass'] should be decoded at that point to make sense of things?
@zteeed
Copy link
Owner

zteeed commented Feb 18, 2022

Hello,

You can make pull request to fix this issue, we'll review it

Regards,
Aurélien

@TurtleWilly
Copy link
Author

The above issue was found by simple code review in the dokuwiki-matrix-notifier which was loosely based on the dokuwiki-discord-notifier. So I kindly informed you about our findings, since the issues stemmed from the original code. I do not have the required discord setup/ credentials to be able to test this in the context of the discord-notifier, so a pull request is impossible from my side. But the issue should be easy to spot and fix, if you look at your code. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants