Well Done! #1241

marcus-j-davies · 2020-12-23T10:19:31Z

marcus-j-davies
Dec 23, 2020

Hello,

I would like to start by saying this library is sick!

I am the owner of node-red-contrib-zwave-dotnet. Its to allow ZWave features in node red.
unfortunately its based on a .Net library where development seems to have stopped, or is slowly becoming stale, neither does it support Security.

Your library zwave-js however:

Seems to be actively maintained
Supports security
from early testing, seems very stable
allows constructing notification reports (via SendReport)
and is, well, 100% javascript

So here is a thanks! 👍

Now for the hidden agenda(s).

I am almost ready to release a successor to node-red-contrib-zwave-dotnet. aptly named node-red-contrib-zwave-js

Which, you may have guessed is based on this library.
Node-Red nodes require an icon, for each functional node.

I would like to know if you have an icon (24x24) that represents zwave-js?
I think this library is awesome, so the more I can help in gaining popularity the better.

ZWaveNode events,
what is the difference between ZWaveNode events "notification" and "value updated".
when I subscribe to "notification" nothing triggers, but the events for "value updated" do trigger.

and the command class in "value updated" is Notification?

Direct serial,
is there a method that allows writing directly to the serial port?
I ask as the ability to say, turn of an LED on some dongles i.e Aeotec Gen 5 Stick, requires sending a special command via its serial interface, being able to do this in zwave-js will be very helpful

Many Thanks

Answered by AlCalzone

Dec 23, 2020

I am unsure why this ended up as a discussion.

That's intended. The third issue "template" leads here to keep the issue tracker free from questions.

I would like to know if you have an icon (24x24) that represents zwave-js?

You could resize the org's logo if that helps:
https://avatars3.githubusercontent.com/u/54627315?s=400&u=87d7635375d212576b5437d878738f6e0e2fd4fd&v=4

what is the difference between ZWaveNode events "notification" and "value updated".

The Notification CC distinguishes between variables with multiple persistent states and events which only have a meaning the instant they are received.
The "notification" event is used exclusively for the latter. The state changes ar…

View full answer

marcus-j-davies · 2020-12-23T11:25:31Z

marcus-j-davies
Dec 23, 2020
Author

Also - apologies, but I am unsure why this ended up as a discussion.

0 replies

AlCalzone · 2020-12-23T12:27:13Z

AlCalzone
Dec 23, 2020
Maintainer

I am unsure why this ended up as a discussion.

That's intended. The third issue "template" leads here to keep the issue tracker free from questions.

I would like to know if you have an icon (24x24) that represents zwave-js?

You could resize the org's logo if that helps:
https://avatars3.githubusercontent.com/u/54627315?s=400&u=87d7635375d212576b5437d878738f6e0e2fd4fd&v=4

what is the difference between ZWaveNode events "notification" and "value updated".

The Notification CC distinguishes between variables with multiple persistent states and events which only have a meaning the instant they are received.
The "notification" event is used exclusively for the latter. The state changes are emitted as "value added" or "value updated" events.

is there a method that allows writing directly to the serial port?

Should be possible through a custom message. Do you have more information on that? Does the stick confirm the messages somehow?

19 replies

AlCalzone Dec 23, 2020
Maintainer

You don't happen to have a log for the Configuration CC route?

marcus-j-davies Dec 23, 2020
Author

The test was performed on some old code of mine, that allows setting configuration values for ZWave Nodes (.Net, C#)
it takes the Node ID, Config Param, Config Value, and the values size.
packs it up - setting the checksum of course and sending to the controller.

the same snippet of code, sets the config values for Non-Controller devices without a problem.
the controller doesn't seem to have a problem with it, as its returning with ACK, it just has no affect.

its as if the controller is trying to search or a node ID of 1 - not realising that its its-self.

I can send you a snippet of the code? - but it's not NodeJS, not sure how useful it will be?

AlCalzone Dec 23, 2020
Maintainer

Thanks but I don't think that will help. It seems that I misunderstood the report.

marcus-j-davies Dec 23, 2020
Author

From what I have read - this controller at least, can't be configured using the normal ConfigurationCCs.
and it needs to be carried out using the functions below.

I'm not sure if this is a restriction on the Serial API Specification - I re-call seeing some threads across the intermaweb, that the serial API does not allow this - I'm not sure how true that is.

I think it does have some ring of truth however, as the Configuration class is asking for the target Node ID, and if controllers cant address them self via the Serial Interface, then this may be the reason.

using the SendMessage approach does work though, so all is not lost.

AlCalzone Dec 23, 2020
Maintainer

Yep, I was just confused by a screenshot which showed the config params in another driver. Seems like they only apply when the stick is included as a secondary controller.
I've raised #1245 to track the necessary work to do this generically for multiple sticks (e.g. UZB).

marcus-j-davies · 2020-12-23T14:13:30Z

marcus-j-davies
Dec 23, 2020
Author

More digging around, I found that 0xF2 is serial API function FUNC_ID_PROPRIETARY_2

#define FUNC_ID_PROPRIETARY_0 0xF0
#define FUNC_ID_PROPRIETARY_1 0xF1
#define FUNC_ID_PROPRIETARY_2 0xF2
#define FUNC_ID_PROPRIETARY_3 0xF3
#define FUNC_ID_PROPRIETARY_4 0xF4
#define FUNC_ID_PROPRIETARY_5 0xF5
#define FUNC_ID_PROPRIETARY_6 0xF6
#define FUNC_ID_PROPRIETARY_7 0xF7
#define FUNC_ID_PROPRIETARY_8 0xF8
#define FUNC_ID_PROPRIETARY_9 0xF9
#define FUNC_ID_PROPRIETARY_A 0xFA
#define FUNC_ID_PROPRIETARY_B 0xFB
#define FUNC_ID_PROPRIETARY_C 0xFC
#define FUNC_ID_PROPRIETARY_D 0xFD
#define FUNC_ID_PROPRIETARY_E 0xFE

0 replies

robertsLando · 2020-12-23T14:20:15Z

robertsLando
Dec 23, 2020
Collaborator

@marcus-j-davies Would you mind to move your repo to our zwave-js org? You will keep your admin privileges on it, it's just to help the org grow, also you could use our slack channel where there is a growing community of zwave users :)

1 reply

marcus-j-davies Dec 23, 2020
Author

@robertsLando

Of course.

I have yet to upload it, it should be ready for the public today/tomorrow.
I'm currently porting over to zwave-js right now. (99% there).

I will upload it to my GitHub, and move it over.
it will also appear on the node-red pallet menu after a few hours once I publish to NPM allowing users to use the node in there flow.

👍

marcus-j-davies · 2020-12-23T21:09:40Z

marcus-j-davies
Dec 23, 2020
Author

@robertsLando @AlCalzone.

I'm pretty much ready to make my repo public (and publish on NPM - therefore Node Red plugin menu).
I won't do it tonight, as I want to check it over with a fresh pair of eyes tomorrow.

Are you still interested in having this apart of the ZWave-JS org?
Naturally, you will want to check this for your self I would have thought?

Im not actually sure of this process - do I still retain rights over it?

2 replies

AlCalzone Dec 23, 2020
Maintainer

You'll have to transfer the repo into the org - I'll give you admin rights afterwards. This means you should be able to do everything in your repo - except install apps, which I'll need to do.

I don't use Node-Red, so I won't be able to check myself, except for a short look at your source code.

Having it all in one org makes it easier to collaborate, since everything is using node-zwave-js under the hood. For example if someone opens an issue in your repo that is actually something that needs to be done in node-zwave-js, transferring the issue is easy.

Maybe we should do it next week though, holidays and all 🎅🏻

marcus-j-davies Dec 23, 2020
Author

Oh yeah - forgot about the holidays!
dam!. I need to get stuff for my children 😉

marcus-j-davies · 2020-12-28T11:37:49Z

marcus-j-davies
Dec 28, 2020
Author

Howdy @robertsLando @AlCalzone,

Hope your holidays are all well and jolly!

My repo is now public, I will be publishing to NPM in the next hour or so (will Appear in Node-Red pallet menu soon after)

node-red-contrib-zwave-js

The inertesting reads are : zwave-js.js which is the Nodes main logic file, and FunctionMaps.json
which bridges the called functions on my plugin , and 'pipes' them though to zwave-js

i.e my node takes a message of

{
  payload: {
    class: "WakeInterval",
    operation: "Set",
    node: 4,
    params: [
      3600,
      0x01
    ]
  }
}

FunctionMaps.json will take the class and operation parameters and return Wake Up for the target Command Class and setInterval for the method

This way - the node itself does not need to have large list of functions.
this is achieved with the following line.

let ZWJSC = Driver.controller.nodes.get(Node).commandClasses[Map.MapsToClass];
await ZWJSC[Func.MapsToFunc].apply(ZWJSC, Params);

This means exposing further command classes for node-red - is only matter of adding an entry to the json file.

Give the readme a once over, it should be self explanatory

25 replies

AlCalzone Dec 30, 2020
Maintainer

Okay, I guess I need to add you to the org.

AlCalzone Dec 30, 2020
Maintainer

Try again :)

marcus-j-davies Dec 30, 2020
Author

The deed is done. 👍

marcus-j-davies Dec 30, 2020
Author

just for info.

I don't use release tagging on the repo - the plug-in is installed via red's user Interface by listing NPM packages.

Main
The code that represents the current version on NPM.

Dev
Work in progress.

PR's , commits should be on Dev, then naturally, I will merge into Main, and publish to NPM.

AlCalzone Dec 30, 2020
Maintainer

Now you are admin again. Feel free to manage your repo as you like. Too busy with node-zwave-js to care for that ;)

FYI, you can join our Slack for easier discussions related to development discussions:
https://join.slack.com/t/zwave2mqtt/shared_invite/enQtNjc4NjgyNjc3NDI2LTc3OGQzYmJlZDIzZTJhMzUzZWQ3M2Q3NThmMjY5MGY1MTc4NjFiOWZhZWE5YjNmNGE0OWRjZjJiMjliZGQyYmU

marcus-j-davies · 2021-01-06T22:12:01Z

marcus-j-davies
Jan 6, 2021
Author

@AlCalzone,

I don't want to open up another issue/discussion - So I'm recycling.
it's just a quick question if you don't mind.

I'm adding support for setValue on the node-red plugin.

However that is not possible for more complex values such as transition durations or methods that require multiple parameters.

Just to clarify - ANY CC method that requires more than 1 parameter is not supported?
As an example, you cant set a configuration value as it requires the param ID, the value and the length, like-wise for the addNodes, removeNodes methods of the Association class

just want to confirm that I understand the limitation, so I can update the read me on its use for Node-Red users.

1 reply

AlCalzone Jan 7, 2021
Maintainer

You can set configuration values. Documentation is missing, but you could check the *CC.ts files for something like this:

protected [SET_VALUE]: SetValueImplementation

and figure out which properties it supports. For the most values it should be able to figure out the additional (meta) parameters, there are just some that cannot be easily expressed. Param ID is part of the valueID you have to supply.

Associations have to be managed through the corresponding methods on controller.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Well Done! #1241

{{title}}

Replies: 7 comments 48 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Select a reply

Well Done! #1241

marcus-j-davies Dec 23, 2020

Replies: 7 comments · 48 replies

marcus-j-davies Dec 23, 2020 Author

AlCalzone Dec 23, 2020 Maintainer

AlCalzone Dec 23, 2020 Maintainer

marcus-j-davies Dec 23, 2020 Author

AlCalzone Dec 23, 2020 Maintainer

marcus-j-davies Dec 23, 2020 Author

AlCalzone Dec 23, 2020 Maintainer

marcus-j-davies Dec 23, 2020 Author

robertsLando Dec 23, 2020 Collaborator

marcus-j-davies Dec 23, 2020 Author

marcus-j-davies Dec 23, 2020 Author

AlCalzone Dec 23, 2020 Maintainer

marcus-j-davies Dec 23, 2020 Author

marcus-j-davies Dec 28, 2020 Author

AlCalzone Dec 30, 2020 Maintainer

AlCalzone Dec 30, 2020 Maintainer

marcus-j-davies Dec 30, 2020 Author

marcus-j-davies Dec 30, 2020 Author

AlCalzone Dec 30, 2020 Maintainer

marcus-j-davies Jan 6, 2021 Author

AlCalzone Jan 7, 2021 Maintainer

marcus-j-davies
Dec 23, 2020

Replies: 7 comments 48 replies

marcus-j-davies
Dec 23, 2020
Author

AlCalzone
Dec 23, 2020
Maintainer

AlCalzone Dec 23, 2020
Maintainer

marcus-j-davies Dec 23, 2020
Author

AlCalzone Dec 23, 2020
Maintainer

marcus-j-davies Dec 23, 2020
Author

AlCalzone Dec 23, 2020
Maintainer

marcus-j-davies
Dec 23, 2020
Author

robertsLando
Dec 23, 2020
Collaborator

marcus-j-davies Dec 23, 2020
Author

marcus-j-davies
Dec 23, 2020
Author

AlCalzone Dec 23, 2020
Maintainer

marcus-j-davies Dec 23, 2020
Author

marcus-j-davies
Dec 28, 2020
Author

AlCalzone Dec 30, 2020
Maintainer

AlCalzone Dec 30, 2020
Maintainer

marcus-j-davies Dec 30, 2020
Author

marcus-j-davies Dec 30, 2020
Author

AlCalzone Dec 30, 2020
Maintainer

marcus-j-davies
Jan 6, 2021
Author

AlCalzone Jan 7, 2021
Maintainer