Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show date of Zniffer captures #4115

Open
kpine opened this issue Feb 3, 2025 · 5 comments · May be fixed by #4118
Open

Show date of Zniffer captures #4115

kpine opened this issue Feb 3, 2025 · 5 comments · May be fixed by #4118
Assignees
Labels
enhancement New feature or request

Comments

@kpine
Copy link
Contributor

kpine commented Feb 3, 2025

Is your feature request related to a problem? Please describe.
The zniffer captures show a timestamp but no date. If I have a multi-day capture I might not remember which timestamp goes with which date.

Describe the solution you'd like

  1. A date column
  2. Or a date field in the details pane

Describe alternatives you've considered
None

Additional context

Image

@kpine kpine added the enhancement New feature or request label Feb 3, 2025
@robertsLando
Copy link
Member

@AlCalzone I would be for the date in details, WDYT?

@AlCalzone
Copy link
Member

We had that at the start and it would take up too much space for short captures.

Maybe have Z-Wave JS UI check if the first and last capture frame are on different dates and then show the date?

@kpine
Copy link
Contributor Author

kpine commented Feb 3, 2025

What about a tooltip when I hover over the time? Not exactly discoverable, but maybe good enough.

What kind of device are you trying to optimize for where it would take up too much space in the details pane? Here's the same trace opened in the SiLabs Zniffer in Windows:

Image

Even with date as column, there's no problem showing all the information on a laptop with 1980x1080 resolution scaled to 125% (I realize the browser does take up a bit more UI space though).

Related to the date and time, any idea what's going on in the SiLabs Zniffer? Is it expected that loading a ZLF generated from Z-Wave JS is compatible? The timestamp shown in ZUI is the correct one, while SiLabs is shifted, and obviously the date is wrong no matter which way it's read.

@AlCalzone
Copy link
Member

The Z-UI Zniffer has quite a bit more padding around the data. We might need to reduce that even further, because right now it doesn't come close to the information density of the offical application.

As for the timestamps, this is one of the known open issues:
https://github.com/zwave-js/node-zwave-js/issues?q=is%3Aissue%20state%3Aopen%20zniffer

@robertsLando
Copy link
Member

robertsLando commented Feb 4, 2025

Could this be a valid solution?
#4118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants