Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial implementation of custom cache key #26

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

veeshi
Copy link
Contributor

@veeshi veeshi commented Jun 29, 2023

Initail implementation for #25

Some things of note:

  • The cache_key closure is wrapped in an Arc to allow the HttpCache struct to be cloned.
  • The CacheManager function signatures were changed to take just the cache key.
  • An override cache key parameter was added to the HttpCacheOptions.create_cache_key function to not change the behaviour for is_get_head.
  • All tests are passing and a test was added to the client_reqwest tests called custom_cache_key.

@06chaynes 06chaynes changed the base branch from latest to develop June 29, 2023 22:37
@06chaynes
Copy link
Owner

Created a develop branch, probably should have a long time ago but 🤷

Set that branch as the target and will hopefully have some time later to check out the changes

Copy link
Owner

@06chaynes 06chaynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience on this, had a birthday the other day so just getting back around to this. Changes look good to me!

@06chaynes 06chaynes merged commit b20c041 into 06chaynes:develop Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants