[1] aiGoalFollowWayPts::Update() #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes 1) Code compiles in Debug mode and runs fine in-game at first glance (e.g. change "Car->Sim.ICS.AngularMomentum *= 0.1f;") 2) Doesn't compile in Final mode: ...\mmai\aiGoalFollowWayPts.cpp(138,59): error C2220: the following warning is treated as an error ...\mmai\aiGoalFollowWayPts.cpp(138,59): warning C4244: '=': conversion from 'i32' to 'i16', possible loss of data 3) IDA suggest "f32 arg10" instead of the current "i16 arg10" for the function "DetermineOppMapComponent"
0x1F9F1
reviewed
Oct 21, 2023
The code is ready for review
0x1F9F1
reviewed
Dec 28, 2023
| @@ -55,3 +57,124 @@ b32 aiGoalFollowWayPts::Context() | |||
| return false; | |||
| } | |||
| } | |||
|
|
|||
| i32 aiGoalFollowWayPts::GetWayPtId(i16 index, i32 num_waypts) | |||
There was a problem hiding this comment.
Was there a reason for passing in num_waypts instead of using NumWayPts directly?
There was a problem hiding this comment.
No, it was an oversight. I changed it now
| Car->Sim.Steering = 0.0f; | ||
| Car->Sim.Brakes = 0.0f; | ||
| Car->Sim.Engine.Throttle = 1.0f; | ||
| return; |
There was a problem hiding this comment.
I think this return should be outside the inner if
Comment on lines
61
to
63
| #define CAR_NOT_STUCK 0 | ||
| #define CAR_MAYBE_STUCK 1 | ||
| #define CAR_STUCK 2 |
There was a problem hiding this comment.
Move these to the mmStuck header
- I'm still unsure how to interpret `unk_var1` (v28) - For `unk_var2` (v27) it might be similar to the CAR_STUCK constants in the context of collision (looking at the related functions)
|
The code builds in Final mode and works in the game. Before merging, maybe a stylistic check on your side to see if everything is OK? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
...\mmai\aiGoalFollowWayPts.cpp(138,59): error C2220: the following warning is treated as an error
...\mmai\aiGoalFollowWayPts.cpp(138,59): warning C4244: '=': conversion from 'i32' to 'i16', possible loss of data