Implement mmBoundTemplate::ComputeEdges() #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsure about the line: `v1 = *((__int16 *)&this->Polygons[j + 1].MtlIndex + num_verts);`
0x1F9F1
reviewed
Mar 23, 2024
| total_verts += Polygons[i].GetNumVerts(); | ||
| } | ||
|
|
||
| i32* edge_1s = new i32[4 * total_verts]; |
There was a problem hiding this comment.
The code allocates 4 * total_verts bytes, which is just total_verts ints.
Comment on lines
+54
to
+55
| i32 v1 = poly.MtlIndex + num_verts; // ? | ||
| // Original line: v1 = *((__int16 *)&this->Polygons[j + 1].MtlIndex + num_verts); |
There was a problem hiding this comment.
It's doing poly.VertIndices[num_verts - 1] (MtlIndex is stored 2 bytes before the VertIndices)
| if (!EdgeInList(v1, v2, num_edges, edge_1s, edge_2s)) | ||
| { | ||
| edge_1s[num_edges] = v1; | ||
| edge_2s[num_edges++] = v2; |
There was a problem hiding this comment.
I'd rather move the num_edges++ to a separate line after, since multiple things rely on it in this branch.
|
|
||
| i32 num_edges = 0; | ||
|
|
||
| for (i32 j = 0; j < NumPolys; ++j) |
There was a problem hiding this comment.
This can use i, since the previous one isn't used at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure about the line:
v1 = *((__int16 *)&this->Polygons[j + 1].MtlIndex + num_verts);