Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hash meddler error #285

Merged
merged 2 commits into from
Jan 27, 2025
Merged

fix: hash meddler error #285

merged 2 commits into from
Jan 27, 2025

Conversation

goran-ethernal
Copy link
Collaborator

Description

This PR fixes the issue when running aggsender with zkevm-eth-txmanager, where both of them have their own HashMeddler implementation. eth-txmanager was missing a logic for HashMeddler that aggsender needs.

Fix was introduced in the zkevm-eth-txmanager PR: 0xPolygon/zkevm-ethtx-manager#93. This PR updates the dependency and adds a new UT.

Fixes # (issue)

Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just tag the new version on the zkevm-ethtx-manager and reference it, but otherwise LGTM!

@goran-ethernal goran-ethernal merged commit 2f7ed63 into develop Jan 27, 2025
14 checks passed
@goran-ethernal goran-ethernal deleted the fix/hash-meddler-error branch January 27, 2025 08:52
goran-ethernal added a commit that referenced this pull request Jan 27, 2025
* fix: a small change in

* fix: update zkevm-ethtx-manager to v0.2.4 and bump sql-migrate to v1.7.1

---------

Co-authored-by: Stefan Negovanović <[email protected]>
goran-ethernal added a commit that referenced this pull request Jan 27, 2025
* fix: a small change in

* fix: update zkevm-ethtx-manager to v0.2.4 and bump sql-migrate to v1.7.1

---------

Co-authored-by: Stefan Negovanović <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants