-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hash meddler error #285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just tag the new version on the zkevm-ethtx-manager and reference it, but otherwise LGTM!
4192451
to
f95d0e2
Compare
rachit77
approved these changes
Jan 27, 2025
f95d0e2
to
8cf5d72
Compare
|
goran-ethernal
added a commit
that referenced
this pull request
Jan 27, 2025
* fix: a small change in * fix: update zkevm-ethtx-manager to v0.2.4 and bump sql-migrate to v1.7.1 --------- Co-authored-by: Stefan Negovanović <[email protected]>
goran-ethernal
added a commit
that referenced
this pull request
Jan 27, 2025
* fix: a small change in * fix: update zkevm-ethtx-manager to v0.2.4 and bump sql-migrate to v1.7.1 --------- Co-authored-by: Stefan Negovanović <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue when running
aggsender
withzkevm-eth-txmanager
, where both of them have their ownHashMeddler
implementation.eth-txmanager
was missing a logic forHashMeddler
thataggsender
needs.Fix was introduced in the
zkevm-eth-txmanager
PR: 0xPolygon/zkevm-ethtx-manager#93. This PR updates the dependency and adds a new UT.Fixes # (issue)