This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
Fix missing feeRecipientAddress in order creation in scenario execute_transaction #376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert one modification done in commit 402c161 in the order creation in the
execute_transaction
scenario.It sets the value
NULL_ADDRESS
tofeeRecipientAddress
in the order. But, actually there is a variablefeeRecipientAddress
containing thesender
.Here is what the commit 402c161 changes:
Source: 402c161#diff-ef096bf973c00c822cc64544b6e0364735358e0db5c7915e7df4a7c8e7968d8cL111-R114
This PR simply reverts this modification.
Moreover, I think the
senderAddress
should also be set tosender
to only authorisedsender
to submit the order. What do you think?