Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Fix missing feeRecipientAddress in order creation in scenario execute_transaction #376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NicolasMahe
Copy link

@NicolasMahe NicolasMahe commented Jun 29, 2021

Revert one modification done in commit 402c161 in the order creation in the execute_transaction scenario.

It sets the value NULL_ADDRESS to feeRecipientAddress in the order. But, actually there is a variable feeRecipientAddress containing the sender.

Here is what the commit 402c161 changes:

-        feeRecipientAddress,
+        feeRecipientAddress: NULL_ADDRESS,

Source: 402c161#diff-ef096bf973c00c822cc64544b6e0364735358e0db5c7915e7df4a7c8e7968d8cL111-R114

This PR simply reverts this modification.

Moreover, I think the senderAddress should also be set to sender to only authorised sender to submit the order. What do you think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant