Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token API v0.0.2: Add erc721 minting #239

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Token API v0.0.2: Add erc721 minting #239

merged 1 commit into from
Apr 10, 2023

Conversation

ilikesymmetry
Copy link
Member

had to do some re-organizing of the file structure and creation route:

  • some collections just set one set of metadata for all minted tokens, which is an alternative option to setting metadata per tokenId
  • minting arguments are different enough between erc20/721/1155 that separate routes will provide a cleaner interface than polymorphic routes with different body combinations
    • potentially thinking about changing the creation route to this pattern too

@vercel
Copy link

vercel bot commented Apr 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app ✅ Ready (Inspect) Visit Preview Apr 10, 2023 3:07pm

@ilikesymmetry ilikesymmetry marked this pull request as ready for review April 10, 2023 15:07
@ilikesymmetry ilikesymmetry merged commit 7ded153 into main Apr 10, 2023
@ilikesymmetry ilikesymmetry deleted the token-api/docs-mint branch April 10, 2023 15:08
@ilikesymmetry ilikesymmetry changed the title Token API v0.2: Add erc721 minting Token API v0.0.2: Add erc721 minting Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ilikesymmetry