Support connections to Unix domain sockets #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-cube
reviewed
Oct 6, 2023
c-cube
approved these changes
Oct 6, 2023
|
I rebased and added the connection_spec_unix_socket. Have a look at my comment on your suggestion to see if that makes sense or if I'm still missing something. :) |
|
thank you! :) |
|
Thank you for merging! 🎉 |
|
No worries 😁. It's also released on opam!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not currently possible to connect to a Redis server that uses Unix domain sockets.
Using Unix domain sockets is handy because it allows using filesystem permissions to control access, and because there's no need to worry about conflicting ports.
This PR introduces support for Unix domain sockets by setting the socket path in the
hostand settingportto0.I've taken this approach instead of extending the
connection_specor turning it into a variant type because I suspect a lot of code usesconnection_specdirectly and this would be incompatible.(I think it would be ideal if we supported a single string (
redis://URL) to specify connection information, as this makes managing client configuration a lot easier and allows extending supported connection types and options without having to change the code that uses this library. But I think that's for another day.)