Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install turbo as optional dependency #629

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

Manussakis
Copy link
Member

@Manussakis Manussakis commented Oct 24, 2023

Description of the Change

Closes #617

How to test the Change

Run npm install from machines with different architectures and platforms:

  • Darwin x64
  • Darwin arm64
  • Linux x64
  • Linux arm64
  • Windows x64
  • Windows arm64

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

⚠️ No Changeset found

Latest commit: 613566b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
headstarwp ✅ Ready (Inspect) Visit Preview Oct 24, 2023 10:12pm

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@Manussakis Manussakis marked this pull request as ready for review October 26, 2023 14:53
@Manussakis Manussakis requested a review from nicholasio October 26, 2023 14:55
@nicholasio nicholasio merged commit 36e20be into develop Oct 27, 2023
6 checks passed
@nicholasio nicholasio deleted the fix/install-turbo-as-optional-dependency branch October 27, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional dependencies for the turbo package
2 participants