Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the npm_and_yarn group across 1 directory with 2 updates #234

Merged
merged 7 commits into from
Nov 20, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 20, 2024

Bumps @10up/cypress-wp-utils from 0.2.0 to 0.4.0
Bumps @wordpress/env from 9.2.0 to 10.12.0
Bumps cypress from 13.3.0 to 13.16.0
Bumps cypress-mochawesome-reporter from 3.4.0 to 3.8.2
Downgrades @wordpress/scripts to 27.9.0
Add additional E2E tests

Bumps the npm_and_yarn group with 2 updates in the / directory: ws and @wordpress/scripts.

Updates ws from 7.5.10 to 8.18.0

Release notes

Sourced from ws's releases.

8.18.0

Features

  • Added support for Blob (#2229).

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

... (truncated)

Commits
  • 976c53c [dist] 8.18.0
  • 59b9629 [feature] Add support for Blob (#2229)
  • 0d1b5e6 [security] Use more descriptive text for 2017 vulnerability link
  • 15f11a0 [security] Add new DoS vulnerability to SECURITY.md
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • Additional commits viewable in compare view

Updates @wordpress/scripts from 30.1.0 to 30.5.1

Changelog

Sourced from @​wordpress/scripts's changelog.

30.5.1 (2024-11-18)

Bug Fix

  • Revert changes from #61121 that inlined CSS files imported from other CSS files before optimization in the build command.

30.5.0 (2024-11-16)

Bug Fix

  • Make start script more resilient for developer errors (#66752).

30.4.0 (2024-10-30)

Enhancements

  • Add BlueOak-1.0.0 the GPLv2-compatible licenses recognized by check-licenses (#66139).
  • Add an optional --root-folder argument to the plugin-zip command (#61375). By default, the command will use the plugin's name as the root folder of the zip. If the change in the behavior impacted your workflow, you could pass --no-root-folder to remove the root folder.

Internal

  • Refactor to extract license related logic to a reusable module (#66179).

30.3.0 (2024-10-17)

New Features

  • Add new build-blocks-manifest command to generate a PHP file containing block metadata from all block.json files in a project (#65866).

30.2.0 (2024-10-16)

Commits
  • b24995a chore(release): publish
  • b25f82f Update changelog files
  • fdbe988 WP Scripts: Revert changes that inline CSS imports early in the build process...
  • 510540d chore(release): publish
  • 854d8c7 Update changelog files
  • eac92a2 Merge changes published in the Gutenberg plugin "release/19.7" branch
  • dcf4613 chore(release): publish
  • 29094ac Update changelog files
  • 41580fe Merge changes published in the Gutenberg plugin "release/19.6" branch
  • 3c61eb6 chore(release): publish
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps the npm_and_yarn group with 2 updates in the / directory: [ws](https://github.com/websockets/ws) and [@wordpress/scripts](https://github.com/WordPress/gutenberg/tree/HEAD/packages/scripts).


Updates `ws` from 7.5.10 to 8.18.0
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.5.10...8.18.0)

Updates `@wordpress/scripts` from 30.1.0 to 30.5.1
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md)
- [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/scripts)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: "@wordpress/scripts"
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from jeffpaul as a code owner November 20, 2024 03:08
@dependabot dependabot bot added the javascript Pull requests that update Javascript code label Nov 20, 2024
@dependabot dependabot bot requested a review from dkotter as a code owner November 20, 2024 03:08
@dependabot dependabot bot added the type:dependency An issue with a separate library that this project relies upon. label Nov 20, 2024
@jeffpaul jeffpaul added this to the 2.3.0 milestone Nov 20, 2024
@jeffpaul jeffpaul requested review from a team and iamdharmesh and removed request for dkotter, jeffpaul and a team November 20, 2024 13:54
@github-actions github-actions bot added the needs:code-review This requires code review. label Nov 20, 2024
@dkotter
Copy link
Collaborator

dkotter commented Nov 20, 2024

Did some research here as I know this bumps @wordpress/scripts which can cause issues in versions of WordPress less than 6.6. Dependabot first tried to bump this in #227 but Sid modified that to stick to v27.9.0.

Dependabot came back again in #230 to bump that and Faisal merged that in as all tests were passing.

And dependabot is back at it here trying to further bump that version. In testing locally on WP 6.5 (our minimum) noticed the SVG block was no longer working. I've downgraded back to v27.9.0 and that fixes the issue.

Also noticed we had no E2E tests for the block so added that which hopefully will alert us to failures in the future if dependabot tries to push this update on us again.

So for anyone looking at this in the future, until our minimum version of WordPress is 6.6, we shouldn't bump @wordpress/scripts as that will break things.

@dkotter dkotter merged commit 91bcfa6 into develop Nov 20, 2024
16 checks passed
@dkotter dkotter deleted the dependabot/npm_and_yarn/npm_and_yarn-b8526f1e11 branch November 20, 2024 20:10
@dkotter dkotter linked an issue Nov 20, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code needs:code-review This requires code review. type:dependency An issue with a separate library that this project relies upon.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cypress dependency in runtime dependencies
2 participants