Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar message linkify #38

Open
wants to merge 4 commits into
base: 🌨️
Choose a base branch
from

Conversation

ilovecherries
Copy link
Collaborator

This adds a link onto messages that link to the parent page of the message, is targetted at #35 but more changes can be made.

@y-ack
Copy link
Collaborator

y-ack commented Jul 21, 2022

y might appreciate if there were a setting for this to prevent accidental touching on clickscreen--
er, clicking when on touchscreen etc.
since it's such a large hit area.

@ilovecherries
Copy link
Collaborator Author

ilovecherries commented Jul 21, 2022

there's a setting for sidebar linkify now but it's a hack mostly, the better solution would be to replace all of the nodes instead of just swapping it with a CSS hack. also, with this CSS hack, it would be better if the aria-disabled attribute was set to true
edit: the linkify is disabled by default

@12Me21
Copy link
Owner

12Me21 commented Jul 22, 2022

don't have to replace the nodes, just set/remove the href attribute depending on the setting, since <a> without href isn't considered a link

@ilovecherries
Copy link
Collaborator Author

don't have to replace the nodes, just set/remove the href attribute depending on the setting, since <a> without href isn't considered a link

could probably have a data attribute on the comments that stores the page id and then have that be applied to href when necessary

@y-ack y-ack added the old moldy label Aug 10, 2023
@y-ack
Copy link
Collaborator

y-ack commented Aug 10, 2023

has conflicts with master (needs rebase if active)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old moldy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants