Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Edited Label to Page View #50

Draft
wants to merge 1 commit into
base: 🌨️
Choose a base branch
from

Conversation

ilovecherries
Copy link
Collaborator

@ilovecherries ilovecherries commented Dec 21, 2022

This adds an edited label to the page view so that some immediate important information about the page is readily available via the activity data.

image

There is controversy about this, particularly there is concern about the amount of information added to the information bar. As this is beyond the scope of the issue that this is originally made for, I am submitting this as a PR to be
built on later since it seems this relies on some design choices being decided first.

This closes #43.

@y-ack
Copy link
Collaborator

y-ack commented Aug 10, 2023

not comfortable merging this without an available width check, but that's up to @12Me21

@ansxor
Copy link
Contributor

ansxor commented Aug 22, 2023

We probably need to have a strict priority on which information is more important then. Whether it's more important to only show the Edited field or it's important to only show the Created field when the width can't fit both fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants