[Colleen, Drew] Custom tags #71
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re testing against the latest rails using the latest versions of most dependencies.
…. Will change to using the new route method in rspec once 2.14 is released.
…dem page, so I'm removing this duplicate from the dummy app's layout.
… used in the tandem_content markup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/47110619
Biggest part of this pull is upgrading many of the dummy app's dependencies, e.g. rspec, capybara, and what not.
The actual feature is simply exposing a :tag option to the tandem_content_tag helper, so developers can specify a custom tag instead of having every one wrapped in a div.