Skip to content
This repository has been archived by the owner on Jun 25, 2023. It is now read-only.

Initial solution commit #33

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Initial solution commit #33

wants to merge 3 commits into from

Conversation

kseniiaarshinina
Copy link

No description provided.


# RUN python src/utils.py

EXPOSE 8000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kseniiaarshinina, thank you for the interest in this challenge and your wonderful solution. We couldnt run our tests -- the Dockerfile is missing an entrypoint and pod was restarting over and over again (we dont use docker-compose for deployment, only helm). Can you please adjust the dockerfile and re-request the review? Thank you in advance!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rsolovev! Thank you for your acknowledgement of my solution. Sure thing, will fix it right away.

Copy link
Collaborator

@rsolovev rsolovev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kseniiaarshinina, thank you for the fixes, now everything launches perfectly -- here are our tests results on a grafana dashboard

If you would like to work on your solution further, you can continue optimizing/improving it and re-request our review once done. Any contribution during the challenge period will be taken into account while choosing a winner. Many thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants