remove never needed pdf service from rejector

18F · Jun 25, 2019 · c6bc52e · c6bc52e
1 parent e405c15
commit c6bc52e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/api/admin/reject.go b/api/admin/reject.go
@@ -13,15 +13,13 @@ import (
 type Rejecter struct {
 	db    api.DatabaseService
 	store api.StorageService
-	pdf   api.PdfService
 }
 
 // NewRejecter returns a configured Rejecter
-func NewRejecter(db api.DatabaseService, store api.StorageService, pdf api.PdfService) Rejecter {
+func NewRejecter(db api.DatabaseService, store api.StorageService) Rejecter {
 	return Rejecter{
 		db,
 		store,
-		pdf,
 	}
 }
 

diff --git a/api/integration/clear_yes_no_test.go b/api/integration/clear_yes_no_test.go
@@ -21,7 +21,7 @@ func TestClearEmptyAccount(t *testing.T) {
 	services := cleanTestServices(t)
 	account := createTestAccount(t, services.db)
 
-	rejector := admin.NewRejecter(services.db, services.store, nil)
+	rejector := admin.NewRejecter(services.db, services.store)
 
 	err := rejector.Reject(account)
 	if err != nil {
@@ -107,7 +107,7 @@ func rejectSection(t *testing.T, services serviceSet, json []byte, sectionName s
 		t.Fatal("Failed to save JSON", resp.StatusCode)
 	}
 
-	rejector := admin.NewRejecter(services.db, services.store, nil)
+	rejector := admin.NewRejecter(services.db, services.store)
 	err := rejector.Reject(account)
 	if err != nil {
 		t.Fatal("Failed to reject account: ", err)
@@ -1036,7 +1036,7 @@ func TestClearComplexSectionNos(t *testing.T) {
 				t.Fatal("Failed to save JSON", resp.StatusCode)
 			}
 
-			rejector := admin.NewRejecter(services.db, services.store, nil)
+			rejector := admin.NewRejecter(services.db, services.store)
 			err := rejector.Reject(account)
 			if err != nil {
 				t.Fatal("Failed to reject account: ", err)

diff --git a/api/integration/reject_test.go b/api/integration/reject_test.go
@@ -79,7 +79,7 @@ func TestDeleteSingaturePDFs(t *testing.T) {
 	}
 
 	// Reject this submission
-	rejector := admin.NewRejecter(services.db, services.store, nil)
+	rejector := admin.NewRejecter(services.db, services.store)
 	err := rejector.Reject(account)
 	if err != nil {
 		t.Fatal("Failed to reject account: ", err)