Fix issues that bother Blackboard, update for php-jwt v6.10.0 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 31, 2024 10:44
See sec 4.5.1 and Appendix B in Deep Linking v2.
For an empty 'custom', json_encode() produces an empty array. Blackboard wants an empty object and errors out on empty arrays. Omitting an empty 'custom' satisfies Blackboard while having no impact on Canvas or Moodle.
…rameter This can be used to provide the same kid used in constructing a JWKS endpoint with LTI\JWKS_Endpoint::new().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to work with php-jwt v6.10.0, fix two small bugs in compliance with the Deep Linking v2 spec that caused problems for Blackboard, allow deep linking replies to explicitly specify a Key ID.