Remove Python 2.7 syntax and undeclared dependency #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removed lines no longer have an effect in a Python 3 codebase.
- re is not used anywhere in the model generated code - inspect.getfullargspec is available from Python 3.4 onwards
This removes the need to disable flake8 in these modules.
The value of each key-value pair is ignored, just loop over the keys.
These modules are indirectly imported, but documentation shows these need to be explicitly available for consumers of this library. Without adding client and models to the exported names here, type checkers and linters will flag using `onepasswordconnectsdk.client` and `onepasswordconnectsdk.models` as invalid.
volodymyrZotov
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies some general clean-ups to the codebase:
newer so older syntax is no longer needed.
__all__to explicitly mark imports as exported, removing the need tosilence Flake8 linting.
These changes should lower the support burden of the codebase and fixes #85