Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] Augment and Validate Project Date Data (Breaking Change) #24

Merged
merged 26 commits into from
May 14, 2024

Conversation

schneedotdev
Copy link
Contributor

@schneedotdev schneedotdev commented May 1, 2024

Summary

Every project within projects.json that has a category of 'repo' has been given a date field called createdAt. Projects that had a field in the past called date have now been replaced with this new property: createdAt (breaking change)

Related Issues and MRs

Closing #23

What changed

  • Add a date for each project that has a category of "repo"
  • Update Project struct in validate.go. Date field is now required for all project categories.
  • date has become createdAt (breaking change)
  • Update CONTRIBUTING.md with data shape information.

Steps for reviewer

  1. Pull changes
git checkout brian/date-validation
  1. Set the currentBranch value on line 31 of validate.go to "main"
  2. Run the validator on projects.json:
go run validate.go
  1. Ensure all projects have a date field called createdAt
  2. Ensure the meta data of the CreatedAt field is accurate within validate.go

Additional resources

N/A

@schneedotdev schneedotdev changed the title [DEV] Augment and Validate Project Date Data (Breaking Change)d [DEV] Augment and Validate Project Date Data (Breaking Change) May 1, 2024
@schneedotdev schneedotdev requested review from meek and jodyheavener May 1, 2024 20:14
@jodyheavener
Copy link
Member

Where did we end up with 301 redirects? I see the Twilio one is causing this to fail. It might be worth omitting this entry if there isn't a reasonable workaround.

@schneedotdev
Copy link
Contributor Author

Where did we end up with 301 redirects? I see the Twilio one is causing this to fail. It might be worth omitting this entry if there isn't a reasonable workaround.

Just fixed the error. It looks like the link was resolving to one that included: en-us. I replaced the URL with the revised one and our validation checks pass.

@schneedotdev schneedotdev removed the request for review from meek May 14, 2024 02:21
@jodyheavener jodyheavener reopened this May 14, 2024
@jodyheavener jodyheavener merged commit 42c33ab into main May 14, 2024
@schneedotdev
Copy link
Contributor Author

Thank you!

@schneedotdev schneedotdev deleted the brian/date-validation branch May 14, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants