Merge pull request #175 from dethancosta/main

Ignore instances of ${{ ... }} when creating a CodeLens suggestion
1Password · May 21, 2024 · 5ed6d6a · 5ed6d6a
2 parents 39c927b + de35691
commit 5ed6d6a
Showing 1 changed file with 15 additions and 8 deletions.
diff --git a/src/language-providers/code-lens.ts b/src/language-providers/code-lens.ts
@@ -31,12 +31,19 @@ export const provideCodeLenses = (document: TextDocument): CodeLens[] => {
 		parser = new GenericParser(document);
 	}
 
-	return parser.getMatches().map(
-		({ range, fieldValue, suggestion }) =>
-			new CodeLens(range, {
-				title: "$(lock) Save in 1Password",
-				command: COMMANDS.SAVE_VALUE_TO_ITEM,
-				arguments: [[{ location: range, fieldValue, suggestion }]],
-			}),
-	);
+	return parser
+		.getMatches()
+		.filter(
+			// Ignore values within secret template variables
+			({ range, fieldValue, suggestion }) =>
+				!new RegExp(/\${{(.*?)}}/).test(fieldValue),
+		)
+		.map(
+			({ range, fieldValue, suggestion }) =>
+				new CodeLens(range, {
+					title: "$(lock) Save in 1Password",
+					command: COMMANDS.SAVE_VALUE_TO_ITEM,
+					arguments: [[{ location: range, fieldValue, suggestion }]],
+				}),
+		);
 };