Add SubscribeStar.com #8215
Add SubscribeStar.com #8215
Conversation
entries/s/subscribestar.com.json
Outdated
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "Patreon": { | |||
There was a problem hiding this comment.
Please change the name to SubscribeStar.com
There was a problem hiding this comment.
I updated the name to SubscribeStar, since that seemed more in line with the other sites. If I should be including the root domain, let me know and I'll add it.
There was a problem hiding this comment.
Good thinking!
That would normally be the preferred option, however as the name on the website is "SubscribeStar.com", it's better to stick with their preferred brand name.
When it comes to branding and trademarks it's always better to just go with what the company does. Makes for less legal trouble 😅
There was a problem hiding this comment.
I have corrected the name now, and I'll try to follow this rule for future PRs as well.
entries/s/subscribestar.com.json
Outdated
| { | ||
| "Patreon": { | ||
| "domain": "subscribestar.com", | ||
| "url": "https://www.subscribestar.com/", |
There was a problem hiding this comment.
If you go to https://<domain> and it redirects to the value of the url-element then the url-element isn't needed.
Since this is the case for this PR, please remove the url-element:
| "url": "https://www.subscribestar.com/", |
Signed-off-by: Carl <[email protected]>
There was a problem hiding this comment.
Thank you! 🙂
Your contribution will be visible in around 10 minutes. Sometimes, it takes longer to show up due to server and browser caching.
No description provided.