I-26 - move test environment variables to setup/teardown methods

2gis · Aug 28, 2018 · 1af0a8d · 1af0a8d
1 parent 860b443
commit 1af0a8d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/tests/test_config.py b/tests/test_config.py
@@ -11,11 +11,16 @@ class TestContextGeneration(unittest.TestCase):
     def setUp(self):
         settings.CONFIG_FILE = 'tests/fixtures/config.yaml'
         settings.TEMPLATES_DIR = 'templates/tests'
+        os.environ['CUSTOM_ENV'] = 'My value'
+        os.environ['K8S_CONFIG_DIR'] = '/tmp/kube/'
 
     def tearDown(self):
         if os.path.exists(settings.TEMP_DIR):
             shutil.rmtree(settings.TEMP_DIR)
 
+        os.environ.pop('CUSTOM_ENV')
+        os.environ.pop('K8S_CONFIG_DIR')
+
     def test_config_not_exist(self):
         settings.CONFIG_FILE = 'tests/config.yaml'
         with self.assertRaises(Exception) as context:

diff --git a/tests/test_templating.py b/tests/test_templating.py
@@ -11,11 +11,16 @@ class TestTemplating(unittest.TestCase):
     def setUp(self):
         settings.CONFIG_FILE = 'tests/fixtures/config.yaml'
         settings.TEMPLATES_DIR = 'templates/tests'
+        os.environ['CUSTOM_ENV'] = 'My value'
+        os.environ['K8S_CONFIG_DIR'] = '/tmp/kube/'
 
     def tearDown(self):
         if os.path.exists(settings.TEMP_DIR):
             shutil.rmtree(settings.TEMP_DIR)
 
+        os.environ.pop('CUSTOM_ENV')
+        os.environ.pop('K8S_CONFIG_DIR')
+
     def test_renderer_init(self):
         r = templating.Renderer()
         expected = os.path.join(os.path.dirname(__file__), '../templates')

diff --git a/tox.ini b/tox.ini
@@ -8,8 +8,6 @@ deps = -r {toxinidir}/requirements.txt
         coveralls
 
 setenv = LOG_LEVEL=DEBUG
-    CUSTOM_ENV=My value
-    K8S_CONFIG_DIR=/tmp/kube/
 
 commands = flake8
     coverage erase