Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: GEFEST-856 авторизация в kafka по ключу #462

Closed
wants to merge 11 commits into from

Conversation

DemonNSK
Copy link
Contributor

@DemonNSK DemonNSK commented Jun 28, 2024

Pull Request description

Changelog

  • добавлен деплой пода с counter
  • добавлена поддержка tls для коннектов к kafka в keys для api и counter (можно указать разные kafka), сертификаты и ключ подкладываются в смонтированный в контейнер volume из secret
  • добавлено конфигурирование security protocol и sasl mechanism

Issues

Breaking changes

  • If there are breaking changes, they need to be added to the file Breaking-Changes

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@DemonNSK DemonNSK requested review from a team as code owners June 28, 2024 06:40
charts/keys/templates/counter/statefulset.yaml Outdated Show resolved Hide resolved
charts/keys/templates/secret-deploys.yaml Outdated Show resolved Hide resolved
charts/keys/values.yaml Outdated Show resolved Hide resolved
charts/keys/values.yaml Outdated Show resolved Hide resolved
charts/keys/values.yaml Outdated Show resolved Hide resolved
charts/keys/values.yaml Outdated Show resolved Hide resolved
charts/keys/values.yaml Outdated Show resolved Hide resolved
charts/keys/values.yaml Outdated Show resolved Hide resolved
charts/keys/values.yaml Outdated Show resolved Hide resolved
charts/keys/values.yaml Outdated Show resolved Hide resolved
charts/keys/values.yaml Outdated Show resolved Hide resolved
charts/keys/values.yaml Outdated Show resolved Hide resolved
charts/keys/values.yaml Outdated Show resolved Hide resolved
Co-authored-by: Kirill Salnikov <[email protected]>
charts/keys/values.yaml Outdated Show resolved Hide resolved
charts/keys/values.yaml Outdated Show resolved Hide resolved
Co-authored-by: Kirill Salnikov <[email protected]>
@salkrr
Copy link
Collaborator

salkrr commented Jul 29, 2024

Тикет нужно поменять на GEFEST-856

@DemonNSK DemonNSK changed the title WIP: WAPI-22944 авторизация в kafka по ключу WIP: GEFEST-856 авторизация в kafka по ключу Jul 29, 2024
@DemonNSK
Copy link
Contributor Author

Создал новый pr - #474

@DemonNSK DemonNSK closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants