Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search-api: custom CA certificates support #478

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

zhukov-d-man
Copy link
Collaborator

@zhukov-d-man zhukov-d-man commented Aug 5, 2024

Pull Request description

Changelog

  • Добавлена поддержка кастомных CA

Issues

Breaking changes

  • If there are breaking changes, they need to be added to the file Breaking-Changes

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@zhukov-d-man zhukov-d-man requested review from a team as code owners August 5, 2024 06:14
@endryhold
Copy link
Contributor

Задача на проверку
https://jira.2gis.ru/browse/ONPREM-993

@v-a-v v-a-v merged commit 576873d into develop Aug 26, 2024
14 checks passed
@v-a-v v-a-v deleted the DEVOPS-1332-ca-custom branch August 26, 2024 06:02
# @section customCAs **Custom Certificate Authority**

# @param customCAs.bundle Custom CA [text representation of the X.509 PEM public-key certificate](https://www.rfc-editor.org/rfc/rfc7468#section-5.1)
# @param customCAs.certsPath Custom CA bundle mount directory in the container.
Copy link
Contributor

@v-a-v v-a-v Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhukov-d-man а давай добавим отдельным ПР с описанием что есть дефолт.

# @param customCAs.certsPath Custom CA bundle mount directory in the container. If empty, default: "/usr/local/share/ca-certificates"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants