Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Обновление PRO API до версии 1.35.0 и PRO UI до версии 2.27.0 #481

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Обновление PRO API до версии 1.35.0 и PRO UI до версии 2.27.0 #481

merged 7 commits into from
Aug 28, 2024

Conversation

dmolochnikov
Copy link
Collaborator

@dmolochnikov dmolochnikov commented Aug 8, 2024 •
edited by v-a-v
Loading

Версия PRO API обновлена до 1.35.0

Продуктовые изменения:

Багфиксы:

Техн. изменения:

PRO-UI

Разные правки и дополнения по новым дашбордам
MAJOR:
https://jira.2gis.ru/browse/PRO-4654 разделение values дляя чартов

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@dmolochnikov dmolochnikov marked this pull request as ready for review August 8, 2024 09:23
@dmolochnikov dmolochnikov requested review from a team as code owners August 8, 2024 09:23
@dmolochnikov dmolochnikov marked this pull request as draft August 8, 2024 09:39
@dmolochnikov dmolochnikov force-pushed the PRO-5968-update-helm-chart branch 2 times, most recently from 956fbe1 to b5e5c9a Compare August 8, 2024 10:18
@dmolochnikov dmolochnikov changed the title Обновление PRO API до версии 1.32.0 Обновление PRO API до версии 1.35.0 Aug 22, 2024
@Aveldin1 Aveldin1 changed the title Обновление PRO API до версии 1.35.0 Обновление PRO API до версии 1.35.0 и PRO UI до версии 2.27.0 Aug 22, 2024
@Aveldin1 Aveldin1 marked this pull request as ready for review August 22, 2024 06:41
@endryhold
Copy link
Contributor

https://jira.2gis.ru/browse/ONPREM-1021
Задача на проверку

v-a-v
v-a-v reviewed Aug 26, 2024
View reviewed changes
charts/pro-api/values.yaml Outdated Show resolved Hide resolved
v-a-v
v-a-v reviewed Aug 26, 2024
View reviewed changes
charts/pro-ui/values.yaml
@@ -9,60 +9,72 @@ dgctlDockerRegistry: ''
imagePullPolicy: IfNotPresent
imagePullSecrets: []

ui:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вывод параметров из под секции ui это ломающие изменения старых конфигураций, а следовательно должно быть заполнено в Breaking-Changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для нас критично .Values.ingress

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmolochnikov
перечислите, пожалуйста все ui.old renamed to new в
https://github.com/2gis/on-premise-helm-charts/blob/develop/Breaking-Changes.md

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это не к @dmolochnikov а к Амилю, сейчас призову

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aveldin1
Привет! Ждем правку в Breaking-Changes.md
Тегните, пожалуйста. кого нужно. Релиз на носу)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я добавил все переменные которые были переименованы)

v-a-v
v-a-v reviewed Aug 26, 2024
View reviewed changes
charts/pro-api/values.yaml Outdated Show resolved Hide resolved
v-a-v
v-a-v reviewed Aug 26, 2024
View reviewed changes
charts/pro-ui/values.yaml Outdated Show resolved Hide resolved
v-a-v
v-a-v approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@v-a-v v-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Проверено. Все работает.

@v-a-v v-a-v merged commit 8a561ae into develop Aug 28, 2024
12 checks passed
@v-a-v v-a-v deleted the PRO-5968-update-helm-chart branch August 28, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aveldin1 Aveldin1 Aveldin1 left review comments

@v-a-v v-a-v v-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmolochnikov @endryhold @v-a-v @Aveldin1