Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAPI-23578 Styles API #482

Merged
merged 18 commits into from
Sep 11, 2024
Merged

WAPI-23578 Styles API #482

merged 18 commits into from
Sep 11, 2024

Conversation

pavelgopanenko
Copy link
Collaborator

@pavelgopanenko pavelgopanenko commented Aug 16, 2024

Pull Request description

Changelog

  • Add Styles API

Check-list. Чек-лист код-ревью

Запрос на слияние в develop.

  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@Ashigo
Copy link
Contributor

Ashigo commented Aug 22, 2024

Задача на проверку https://jira.2gis.ru/browse/ONPREM-1018

@pavelgopanenko pavelgopanenko changed the title WIP: WAPI-23578 Styles API WAPI-23578 Styles API Aug 28, 2024
charts/styles-api/templates/NOTES.txt Outdated Show resolved Hide resolved
charts/twins-api/templates/migrate/job.yaml Show resolved Hide resolved
charts/twins-api/templates/api/deployment.yaml Outdated Show resolved Hide resolved
charts/styles-api/values.yaml Outdated Show resolved Hide resolved

# @param log.level Log level. Possible values: `debug`, `info`, `warn`, `error`, `fatal`. **Required**

level: info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А формать логов json по умолчанию? Можно ли управлять?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сейчас "из коробки" можемт только в JSON, если требуется другой формат сообщения нужно дорабатывать


# @section S3 like storage access settings

s3:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не хватает флагов для работы по https

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Завели задачу WAPI-23653

@Ashigo Ashigo merged commit 3a2e92a into develop Sep 11, 2024
2 checks passed
@Ashigo Ashigo deleted the feature_styles_api branch September 11, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants