Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add required field to mapgl ENV values #504

Merged
merged 5 commits into from
Sep 23, 2024
Merged

add required field to mapgl ENV values #504

merged 5 commits into from
Sep 23, 2024

Conversation

Ashigo
Copy link
Contributor

@Ashigo Ashigo commented Sep 18, 2024 •
edited
Loading

Pull Request description

Changelog

  • add required fields to two mapgl ENVs

Issues

Breaking changes

  • If there are breaking changes, they need to be added to the file Breaking-Changes

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@Ashigo Ashigo requested review from a team as code owners September 18, 2024 06:41
@Ashigo Ashigo changed the title add required to values add required field to mapgl ENVvalues Sep 18, 2024
@Ashigo Ashigo changed the title add required field to mapgl ENVvalues add required field to mapgl ENV values Sep 18, 2024
@endryhold endryhold merged commit 01e0d09 into develop Sep 23, 2024
2 checks passed
@endryhold endryhold deleted the feature/ONPREM-1078-fix-required-envs branch September 23, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbelyaev-nsk dbelyaev-nsk dbelyaev-nsk left review comments

@endryhold endryhold endryhold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashigo @endryhold @dbelyaev-nsk