Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.28.2 #505

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Release 1.28.2 #505

merged 2 commits into from
Sep 18, 2024

Conversation

endryhold
Copy link
Contributor

Pull Request description

Changelog

  • Release 1.28.2
  • Fix for mapgl-js-api

Issues

  • ONPREM-1090

Breaking changes

  • If there are breaking changes, they need to be added to the file Breaking-Changes

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@endryhold endryhold requested review from a team as code owners September 18, 2024 07:39
@endryhold endryhold merged commit fa2f9e2 into master Sep 18, 2024
2 checks passed
@endryhold endryhold deleted the Release-1.28.2 branch September 18, 2024 10:23
endryhold added a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants