Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change variables naming #506

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

Efber
Copy link
Contributor

@Efber Efber commented Sep 18, 2024

Pull Request description

Changelog

  • Fix error in template streams/application.conf
  • Change naming from bss-receiver to stat-receiver

Issues

  • ONPREM-843

Breaking changes

  • If there are breaking changes, they need to be added to the file Breaking-Changes

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@Efber Efber marked this pull request as ready for review September 20, 2024 08:54
@Efber Efber requested review from a team as code owners September 20, 2024 08:54
@Efber Efber merged commit 37d1f21 into develop Sep 23, 2024
3 checks passed
@Efber Efber deleted the ONPREM-843-stat-receiver-actualization branch September 23, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants