Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom ca for navi-castle, navi-restrictions, navi-async-matrix #511

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

DimiDr0l
Copy link
Contributor

Pull Request description

Changelog

  • add custom ca for navi-castle, navi-restrictions, navi-async-matrix

Issues

Breaking changes

  • If there are breaking changes, they need to be added to the file Breaking-Changes

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@DimiDr0l DimiDr0l requested review from a team as code owners September 27, 2024 07:37
@dbelyaev-nsk
Copy link
Contributor

задача на проверку https://jira.2gis.ru/browse/ONPREM-1121

@Efber Efber merged commit e7edc6c into develop Oct 1, 2024
3 checks passed
@Efber Efber deleted the fb/DEVOPS-1360_custom_ca branch October 1, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants