Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRO-6241] Обновление PRO API до версии 1.41.1 #513

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

ArtemPolykov
Copy link

Pull Request description

update helm

Changelog

  • set host pro-api.example.com
  • remove appName from api.pod
  • add section backgroundJobs to api.settings
  • api.settings.enableUserAssetsImporter renamed to api.settings.backgroundJobs.enableUserAssetsImporter
  • api.settings.enableAssetsStreaming renamed to api.settings.backgroundJobs.enableAssetsStreaming
  • remove api.settings.auth.permissionsApiKey
  • add section layerGeneration to api.settings
  • add api.settings.layerGeneration.isochroneLayerMaxPointsCount
  • add permissions.settings.auth.apiKey
  • add section tasks by new tasks service
  • add assetPreparer.settings.files
  • add kafka.useReplicaTopics

Issues

https://jira.2gis.ru/browse/PRO-6241

Breaking changes

  • set host pro-api.example.com
  • add section backgroundJobs to api.settings
  • api.settings.enableUserAssetsImporter renamed to api.settings.backgroundJobs.enableUserAssetsImporter
  • api.settings.enableAssetsStreaming renamed to api.settings.backgroundJobs.enableAssetsStreaming
  • add section layerGeneration to api.settings
  • add api.settings.layerGeneration.isochroneLayerMaxPointsCount
  • add permissions.settings.auth.apiKey
  • add section tasks by new tasks service
  • add assetPreparer.settings.files
  • add kafka.useReplicaTopics

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@ArtemPolykov ArtemPolykov requested review from a team as code owners October 1, 2024 11:32
@ArtemPolykov ArtemPolykov force-pushed the PRO-6241-updade-helm branch 2 times, most recently from 81c43d9 to 1d6d61a Compare October 7, 2024 09:51
@dmolochnikov dmolochnikov changed the title [PRO-6241] update files and version [PRO-6241] Обновление PRO API до версии 1.41.1 Oct 8, 2024
@endryhold
Copy link
Contributor

https://jira.2gis.ru/browse/ONPREM-1150
Задача на проверку

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants