[PRO-6845] TileGen API #552
Open
+798
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-loboda
force-pushed
the
PRO-6845-TileGen
branch
4 times, most recently
from
2de64f7 to
5d6e538
Compare
charts/tilegen-api/values.yaml
Outdated
Comment on lines
201
to
209
| ingress: | ||
| enabled: false | ||
| hosts: | ||
| - host: tilegen-api.host |
There was a problem hiding this comment.
лучше полное описание
ingress:
enabled: false
className: nginx
hosts:
- host: tilegen-api.example.com
paths:
- path: /
pathType: Prefix
tls: []
# - hosts:
# - tilegen-api.example.com
# secretName: secret.tls
|
задача на проверку https://jira.2gis.ru/browse/ONPREM-1351 |
v-loboda
force-pushed
the
PRO-6845-TileGen
branch
from
5d6e538 to
2185f44
Compare
v-loboda
force-pushed
the
PRO-6845-TileGen
branch
from
2185f44 to
5bf17a5
Compare
mprudnikov3
reviewed
Jan 20, 2025
| app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} | ||
| {{- end }} | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| {{- end -}} |
There was a problem hiding this comment.
Не хватает пустой строки в конце файла
| s3SecretKey: {{ required "Valid .Values.s3.secretKey required!" .Values.s3.secretKey | b64enc }} | ||
| {{ if .Values.redis.password }} | ||
| redisPassword: {{ .Values.redis.password | b64enc }} | ||
| {{ end }} |
There was a problem hiding this comment.
Не хватает пустой строки в конце файла
| @@ -0,0 +1,25 @@ | |||
| --- | |||
| @@ -0,0 +1,30 @@ | |||
| {{- if .Values.vpa.enabled }} | |||
| --- | |||
| backoffLimit: {{ .Values.taskProcessor.backoffLimit }} | ||
| activeDeadlineSeconds: 43200 | ||
| template: | ||
| spec: |
There was a problem hiding this comment.
@v-loboda, наверное, стоит добавить:
imagePullSecretsimagePullPolicy
| # @param s3.secretKey S3 secret key for accessing the bucket. **Required** | ||
| # @param s3.vectorTilesBucket S3 bucket for storing vector tiles data. **Required** | ||
|
|
||
| s3: |
There was a problem hiding this comment.
Расширенные настройки s3 будем добавлять?
region: ''
secure: false/true
verifySsl: true/false
mprudnikov3
reviewed
Jan 21, 2025
| host: '' | ||
| accessKey: '' | ||
| secretKey: '' | ||
| vectorTilesBucket: '' |
There was a problem hiding this comment.
Давай переименуем в bucket
В описании дается понимание что это за bucket и он один :)
| serviceAccount: runner | ||
| tempPath: /tmp | ||
| allowAnyOrigin: false | ||
| logging: |
There was a problem hiding this comment.
@v-loboda, нету возможности выставить уровень логирования? Debug, Info?
mprudnikov3
reviewed
Jan 21, 2025
| repository: 2gis-on-premise/tilegen-processor | ||
| tag: 1.1.6 | ||
| backoffLimit: 1 | ||
| successfulJobsHistoryLimit: 5 |
There was a problem hiding this comment.
@v-loboda, если из API дергать POST /tasks, то не происходит очистка старых job:
mpr-tilegen-api-task-processor-worker-582nd-gxbmk 0/1 Completed 0 76s
mpr-tilegen-api-task-processor-worker-bc2hz-znmws 0/1 Completed 0 78s
mpr-tilegen-api-task-processor-worker-bfbpd-cw7ff 0/1 Completed 0 79s
mpr-tilegen-api-task-processor-worker-ngpcc-sfqkw 0/1 Completed 0 79s
mpr-tilegen-api-task-processor-worker-pzglw-kxp7g 0/1 Completed 0 78s
mpr-tilegen-api-task-processor-worker-qmmg6-8tqwf 0/1 Completed 0 77s
mpr-tilegen-api-task-processor-worker-ttfhr-m7rx9 0/1 Completed 0 82s
mpr-tilegen-api-task-processor-worker-v4f7d-5tgt5 0/1 Completed 0 11m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description
Changelog
Some changes(A description of the changes proposed in the pull request.)Issues
Issue-123(Link to related issue)Breaking changes
Check-list. Чек-лист код-ревью
helm lint charts/search-api